Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] add config to control whether to init public role permissions #33174

Merged
merged 1 commit into from
May 21, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 20, 2024

issue: #33164
pr: #33165

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (cf77659) to head (5afd2b0).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33174      +/-   ##
==========================================
+ Coverage   82.11%   82.12%   +0.01%     
==========================================
  Files        1005     1005              
  Lines      128043   128049       +6     
==========================================
+ Hits       105140   105166      +26     
+ Misses      18922    18908      -14     
+ Partials     3981     3975       -6     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.48% <100.00%> (+<0.01%) ⬆️
internal/rootcoord/root_coord.go 91.96% <77.77%> (+0.02%) ⬆️

... and 21 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels May 20, 2024
Copy link
Contributor

mergify bot commented May 20, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

…issions

Signed-off-by: SimFG <bang.fu@zilliz.com>
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2a38f5b into milvus-io:2.4 May 21, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants