Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support removing absent tools from ToolContainerBase. #28171

Merged
merged 1 commit into from
May 6, 2024
Merged

Support removing absent tools from ToolContainerBase. #28171

merged 1 commit into from
May 6, 2024
+11 −20

Commits on May 6, 2024

  1. Support removing absent tools from ToolContainerBase. 

    ToolManager.remove_tool calls ToolContainerBase.remove_toolitem
(via a tool_removed_event) and cannot know (due to the lack of API)
whether the tool is actually on the container (it can also be a
keybind-only tool not associated with any entry on the toolbar), so
ToolContainerBase.remove_toolitem should work (as a no-op) even for
tools not present on the container.
    @anntzer
    anntzer committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3d0f153 View commit details
    Browse the repository at this point in the history