Support removing absent tools from ToolContainerBase. #28171
Merged
+11
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GUI: Qt
GUI: wx
GUI: gtk
GUI: tk
topic: canvas and figure manager
labels
timhoffm
approved these changes
May 4, 2024
ToolManager.remove_tool calls ToolContainerBase.remove_toolitem (via a tool_removed_event) and cannot know (due to the lack of API) whether the tool is actually on the container (it can also be a keybind-only tool not associated with any entry on the toolbar), so ToolContainerBase.remove_toolitem should work (as a no-op) even for tools not present on the container.
QuLogic
approved these changes
May 6, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 6, 2024
QuLogic
added a commit
that referenced
this pull request
May 7, 2024
…171-on-v3.9.x Backport PR #28171 on branch v3.9.x (Support removing absent tools from ToolContainerBase.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToolManager.remove_tool calls ToolContainerBase.remove_toolitem (via a tool_removed_event) and cannot know (due to the lack of API) whether the tool is actually on the container (it can also be a keybind-only tool not associated with any entry on the toolbar), so ToolContainerBase.remove_toolitem should work (as a no-op) even for tools not present on the container (and not even set a message in that case, IMO).
Closes #28166 (see example there). Again I'd say this is a symptom of the MEP22 design (toolmanager not knowing whether a tool is actually in the toolcontainer makes things awkward), but let's just go for the minimal fix.
PR summary
PR checklist