Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Java 14 Records #9934

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Add support for Java 14 Records #9934

wants to merge 31 commits into from
+625 −52

Commits on Jun 1, 2024

  1. Distribute errorprone suppression, add -noverify

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    8b30883 View commit details
    Browse the repository at this point in the history

  2. Temporary commit to test nightlies

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    bf921c5 View commit details
    Browse the repository at this point in the history

  3. Disable java21 builds until asm is updated

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    f221ee3 View commit details
    Browse the repository at this point in the history

  4. Roll back noverify, we don't need it with the current build setup

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    8c12319 View commit details
    Browse the repository at this point in the history

  5. Simplest workaround for https://bugs.openjdk.org/browse/JDK-8323657

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    8ce1b1b View commit details
    Browse the repository at this point in the history

  6. Also pass noverify to ci's test.jvmargs

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    6be2fce View commit details
    Browse the repository at this point in the history

  7. Add missing emulation to let Record work 

    Change-Id: If0970f6438dc5b1759497a25a0cbc17ec0fc87f6
    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    ab89048 View commit details
    Browse the repository at this point in the history

  8. Emit and bind synthetic methods for records 

    Change-Id: I07348e44ab0cb35a903bb966b9091cf544c199d9
    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    fc83431 View commit details
    Browse the repository at this point in the history

  9. Rough draft of Record.tostring 

    Change-Id: I9f1e03fe1378708265436b0075c5e4121f478516
    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    01bc585 View commit details
    Browse the repository at this point in the history

  10. Cleaner tostring, and hashcode, equals, and refactored field accessors 

    Change-Id: Icd5177fd72d8e16a04596f7abe1218ac392c243f
    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d5e716f View commit details
    Browse the repository at this point in the history

  11. Correct tostring/equals impl, enable compiling records 

    started stubbing in real tests
    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1b37639 View commit details
    Browse the repository at this point in the history

  12. Start stubbing in some tests

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    665ea1e View commit details
    Browse the repository at this point in the history

  13. Add some basic tests, fix a bug found with zero record components

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    717a714 View commit details
    Browse the repository at this point in the history

  14. Add custom jre emul for ast test

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    3bd95a3 View commit details
    Browse the repository at this point in the history

  15. checkstyle, and fix record tostring so we get obf metadata

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    08638d4 View commit details
    Browse the repository at this point in the history

  16. Add a followup

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    72f6359 View commit details
    Browse the repository at this point in the history

  17. Clean up Record.java

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    b3d06e0 View commit details
    Browse the repository at this point in the history

  18. Roll back other rebase/merge damage

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    85dac34 View commit details
    Browse the repository at this point in the history

  19. Add missing class that tests need, add exceptions in test to fix 

    behavior
    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d250e58 View commit details
    Browse the repository at this point in the history

  20. Another missing method so records compile in tests

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d7e804d View commit details
    Browse the repository at this point in the history

  21. Don't && an extra "true", only use true if no exprs present

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2ae1096 View commit details
    Browse the repository at this point in the history

  22. Always cast to Object to box primitives for record component hash

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9407fef View commit details
    Browse the repository at this point in the history

  23. Fix getClass TODO

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    38fb0c5 View commit details
    Browse the repository at this point in the history

  24. checkstyle and self-review cleanup

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    05bdfb5 View commit details
    Browse the repository at this point in the history

  25. Extract method creation to its own precompilation pass

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4fcc49f View commit details
    Browse the repository at this point in the history

  26. Proposed jsinterop support for records

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0d3ee31 View commit details
    Browse the repository at this point in the history

  27. copyright headers, added a few tests, fixed a bug

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1671282 View commit details
    Browse the repository at this point in the history

  28. Add tests for jsinterop usage in records

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    615bb2d View commit details
    Browse the repository at this point in the history

  29. Self-review

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1ef40b2 View commit details
    Browse the repository at this point in the history

  30. Revert "Proposed jsinterop support for records" 

    This reverts commit cec646b.
    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    083450b View commit details
    Browse the repository at this point in the history

  31. Rework jsinterop support for records to something lighter

    @niloc132
    niloc132 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    14d5e6d View commit details
    Browse the repository at this point in the history