New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Java 14 Records #9934
Draft
niloc132
wants to merge
28
commits into
gwtproject:main
Choose a base branch
from
niloc132:9894-records-test
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If0970f6438dc5b1759497a25a0cbc17ec0fc87f6
Change-Id: I07348e44ab0cb35a903bb966b9091cf544c199d9
Change-Id: I9f1e03fe1378708265436b0075c5e4121f478516
Change-Id: Icd5177fd72d8e16a04596f7abe1218ac392c243f
started stubbing in real tests
niloc132
force-pushed
the
9894-records-test
branch
from
April 7, 2024 18:51
453ffda
to
375f740
Compare
Proposed jsinterop spec changes are implemented - building more tests now, then should be ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements records as Java objects, so they can be transpiled to JS. Unlike in Java bytecode, hashCode/toString/equals have a complete implementation, rather than using method references and constant bootstrap to generate code at runtime.
Before ready to review:
Fixes #9894