Gerrit code reivew #252
Open
Gerrit code reivew #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDesjardins
reviewed
Jul 6, 2017
src/main/markdown/makinggwtbetter.md
Outdated
|
|
||
| Code review is an essential part of contribution workflow : | ||
|
|
||
| Once your code is pushed to gerrit, notifications will be triggered to all reviewers,at this stage your code need jenkins precheck as well +2 in Code-Review to get merged with remote repository,If you are new contributor Jenkins precheck triggering will be followed by +2 in Code-Review by reviewers,whereas existing contributors will be added to Jenkins Trusted group which allows the jenkins precheck without wait for code review. |
There was a problem hiding this comment.
This sentence/sentences needs some formatting :-) . Sometimes missing sometimes to many spaces and a point at the end instead a comma.
tbroyer
reviewed
Jul 6, 2017
src/main/markdown/makinggwtbetter.md
Outdated
| @@ -538,6 +538,12 @@ Finally, to actually create an issue is slightly more involved, but most of the | |||
|
|
|||
| If you have any problems you might want to consult the gerrit documentation on [Uploading Changes](https://gerrit-review.googlesource.com/Documentation/user-upload.html) | |||
|
|
|||
| ### Gerrit code review<a id="gerritcodereview"></a> | |||
|
|
|||
| Code review is an essential part of contribution workflow : | |||
There was a problem hiding this comment.
I love that sentence! 😃
The following paragraph needs some work though. Let me think a bit about it, I'll try to propose a new wording.
Good work on the heading and where to put that section too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added the Gerrit code reivew process
This change is