Skip to content

Commit

Permalink
added gerrit review documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
harikishorekuppa committed Jul 8, 2017
1 parent 055f426 commit b3d2296
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/main/markdown/makinggwtbetter.md
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,10 @@ If you have any problems you might want to consult the gerrit documentation on [

### Gerrit code review<a id="gerritcodereview"></a>
Once your “change” is pushed to gerrit, in order to merge the change it requires to pass through following approval process:

1. Jenkins automated precheck to build and test your “change”.
2. Code-review+2 by reviewers to verify the adherence of coding standards.<br>
2. Code-review+2 by reviewers to verify the adherence to coding standards.

Typically to avoid “spammers” consuming the server resources, jenkins precheck is not enabled by default to the first-time contributors. However, your submitted change can get +1 and +2 from the reviewers. After your first successful contribution, you will be added to the Jenkins trusted contributor list. From the next commit on, you can get your change Jenkins precheck accompanied by code-review +2

### GWT Committers<a id="committers"></a>
Expand Down

0 comments on commit b3d2296

Please sign in to comment.