-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC Midterm Evaluation: Changing the way the serialize, serialize_into and deserialize functions work #2345
Open
FaresAtef1
wants to merge
32
commits into
enigma-dev:AST-Generation
Choose a base branch
from
FaresAtef1:GSoC-Part1
base: AST-Generation
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Midterm GSoC Update
Closes #2326.
This pull request contains updates for my Google Summer of Code (GSoC) project at the midterm evaluation stage.
Second PR (Final Evaluation Part1): Implementing (de)serialization routines for generic data types
Third PR (Final Evaluation Part2): Adding support for JSON format
Existing Errors
Updating Functions
enigma_internal_sizeof
function.serialize_into
function.serialize
function.deserialize
function.resize_buffer_for
function.enigma_internal_deserialize
function.Testing Functions (SOG/unit tests)
enigma_internal_sizeof
function.serialize_into
function.serialize
function.deserialize
function.resize_buffer_for
function.enigma_internal_deserialize
function.game_save_buffer
andgame_load_buffer
Organization
detect_size.h
file.serialization.h
functions.Serialization
directory.serialization_fwd_decl.h
file.To Be Done Before Merging
Size
gist (To have Cleaner Code)Newly Implemented Features
HAS_FREE_FUNCTION
macro indetect_serialization.h
, which is used to determine whether there exists a free function that can be called with a particular signature.HAS_FREE_FUNCTION(NAMESPACE, NAME, PARAMETERS...)
Adding new types for the bytes format
Create a new file in the Types_Impl_Bytes directory for your new type, and then include this file in the bytes_types_serialization_includes.h file.
Every new data type in our system should implement the following functions
is_new_type
is a type trait that should be implemented intype_traits.h
.byte_size
internal_serialize_into_fn
internal_serialize_fn
internal_deserialize_fn
internal_resize_buffer_for_fn
enigma_internal_deserialize_fn
Sample game that is compatible with the AST_Generation branch
Balloon_Pop (It is the same game in the ENIGMA site but with modified scripts).
Ongoing Work
What's Next
GSoC Final Evaluation: Implementing (de)serialization routines for generic data types