-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC Final Evaluation Part2: Adding support for JSON format in the serialization system #2359
Open
FaresAtef1
wants to merge
95
commits into
enigma-dev:AST-Generation
Choose a base branch
from
FaresAtef1:GSoC-Part3
base: AST-Generation
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaresAtef1
commented
Aug 30, 2023
FaresAtef1
commented
Aug 31, 2023
ENIGMAsystem/SHELL/Universal_System/Serialization/detect_serialization.h
Outdated
Show resolved
Hide resolved
dc03
reviewed
Sep 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost finished, very well done!
CommandLine/testing/SimpleTests/game_save_load.multi/game_save_load_basics.sog/create.edl
Outdated
Show resolved
Hide resolved
...esting/SimpleTests/game_save_load.multi/game_save_load_json_integral_floating.sog/create.edl
Outdated
Show resolved
Hide resolved
CommandLine/testing/Tests/JSON_serialization_tests/deserialize_tests.cpp
Outdated
Show resolved
Hide resolved
CommandLine/testing/Tests/JSON_serialization_tests/deserialize_tests.cpp
Outdated
Show resolved
Hide resolved
CommandLine/testing/Tests/JSON_serialization_tests/serialize_into_tests.cpp
Outdated
Show resolved
Hide resolved
.../SHELL/Universal_System/Serialization/Bytes_Serialization/Types_Impl_Bytes/std_queue_stack.h
Outdated
Show resolved
Hide resolved
.../SHELL/Universal_System/Serialization/Bytes_Serialization/Types_Impl_Bytes/std_queue_stack.h
Show resolved
Hide resolved
ENIGMAsystem/SHELL/Universal_System/Serialization/type_traits.h
Outdated
Show resolved
Hide resolved
ENIGMAsystem/SHELL/Universal_System/Object_Tiers/transform_object.h
Outdated
Show resolved
Hide resolved
ENIGMAsystem/SHELL/Universal_System/Object_Tiers/planar_object.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final GSoC Part2 Update
Closes #2326.
This pull request contains updates for my Google Summer of Code (GSoC) project at the Final evaluation stage.
First PR (Midterm Evaluation Part): Changing the way the serialize, serialize_into and deserialize functions work
Second PR (Final Evaluation Part1): Implementing (de)serialization routines for generic data types
Feature Implementation
serialize_into
for all the types.deserialize
for all the types.lua_table
.var
.Object_Tiers
.enigma::Background
.enigma::AssetArray
.game_save_buffer
andgame_load_buffer
.Testing Functions (unit tests/SOG)
serialize_into
.deserialize
.game_save_buffer
andgame_load_buffer
.Organization
bytes_serialization
namespace.JSON_serialization
namespace.Types_Impl_Bytes
.Types_Impl_JSON
.JSON_parsing_utilities.h
.To Be Done Before Merging
detect_serialization.h
.serialization.h
functions.internal_serialize_into_fn
inObject_Tiers
,Background
and tests.split
andfind_value
functions from the functions.remove_whitespaces
function.Adding new types for the JSON format
Create a new file in the Types_Impl_JSON directory for your new type, and then include this file in the JSON_types_serialization_includes.h file.
Every new data type in our system should implement the following functions
internal_serialize_into_fn
internal_deserialize_fn
Sample game that is compatible with the AST_Generation branch
Balloon_Pop (It is the same game in the ENIGMA site but with modified scripts).
Ongoing Work