fix: PHP CodeSniffer on settings.ddev.php for Drupal 8 - 11 #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR.
|
truls1502
changed the title
|
Thank you so much! This was annoying me for so long but I never got around to fixing it. |
This was referenced May 20, 2024
jonesrussell
pushed a commit
to jonesrussell/ddev
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The
settings.ddev.phpfile from Drupal versions 8 to 11 had various PHP CodeSniffer violations.How This PR Solves The Issue
Correcting these PHP CodeSniffer violations using default Drupal rules ensures our Drupal configurations adhere to standard code quality norms and fix the issues.
Manual Testing Instructions
settings.ddev.phpfiles.Automated Testing Overview
This PR does not introduce new functionality that will be covered by existing automated tests. If not, let me know, so we can create a test for it.