-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Drupal - switch to sendmail transport always in settings.ddev.php #6192
fix: Drupal - switch to sendmail transport always in settings.ddev.php #6192
Conversation
… switch to Mailpit
Thanks @doradovictor - Could you please update the OP to show what your situation was and why you ran into this? Thanks! |
Download the artifacts for this pull request:
See Testing a PR. |
I tried to explain it better! 😊 |
Sorry for the conflict here @doradovictor but there was a phpcs-based refactor that went in before yours, Would you mind rebasing this (or just recreating it if that's easier)? |
…_transports_support
@rfay I followed Github instructions and merged master with my branch, resolving conflicts. Is it ok now? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this but makes sense to me.
ddev#6192) [skip ci] Co-authored-by: Víctor Dorado <victor.dorado.asensio@gmail.com> Co-authored-by: Christian López Espínola <penyaskito@penyaskito.com>
The Issue
When you have other default transport than sendmail, DDEV doesn't switch correctly Drupal config to use Mailpit.
We ran into this issue because we were using a custom transport in order to send our mails through an external service (Sendgrid). If "sendmail" is not the default transport, current DDEV tweaking technique for redirecting mail to Mailpit is not taking effect.
How This PR Solves The Issue
It also sets the default transport as sendmail, besides changing the sendmail transport configuration.
Manual Testing Instructions
Configure another transport in Drupal Symfony Mailer and test that it is correctly overriden by DDEV to use Mailpit.