Ensure timestamps of files in ZIP archives are within years 1980-2107 #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done using zipfile.ZipFile's strict_timestamps option, which can be used as soon as Python 3.8 is the minimum supported Python version. Fixes datalad#3753.
|
I have cancelled CI runs as their Python versions still contain Python 3.7 runs, but I lacked permissions to cancel Travis. |
|
@adswa should this PR be updated/taken out of the draft now that 3.8 is the minimal supported? |
|
sorry -- for some reason I thought we already merged #7449 , we haven't! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done using zipfile.ZipFile's strict_timestamps option, which can be used as soon as Python 3.8 is the minimum supported Python version (i.e., it needs #7449 first, thus a draft PR) . Fixes #3753.