-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python EOLed 3.7 support (in setup.py and CI) #7449
base: maint
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint #7449 +/- ##
==========================================
- Coverage 91.56% 91.29% -0.27%
==========================================
Files 325 325
Lines 43444 43444
Branches 5827 5827
==========================================
- Hits 39779 39662 -117
- Misses 3650 3767 +117
Partials 15 15 ☔ View full report in Codecov by Sentry. |
This PR still needs an update for Travis. I have two questions there:
|
There is one travis build that fails like this:
I'm not sure whether its related to the changes here or spurious, but I can't re-trigger the build. |
FTR this was resolved by using |
The one travis run still fails, and I don't get why. The failure happens in the |
well, erroring starts early with
which I checked happened only in that one indeed, no other matrix runs... let's try it with |
With the bump of the misbehaving travis run to Python 3.11 a very old requested git-annex conflicts with other software versions :/ |
dang... I still don't know how/why it gets installed in general: conda-forge/datalad-feedstock#109 . |
e0f819e
to
8c9b005
Compare
note: restarted 1 travis job which hanged in conda |
This PR has been sleeping for a while, mostly because I couldn't figure out the setup-related travis failure described in the comments. But #7492 is planning to remove Travis entirely, so I feel like this could be the opportunity to also move forward with dropping Py3.7 support in this PR. |
@adswa would you have time to get back to this one -- we should really drop that good old 3.7 now ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Although the Travis setup is not removed, Travis is inactive, so it should no longer be a blocker.
- Most testing changes are duplicated in Stop testing on Python 3.7 #7585 where we currently explore the consequences of macOS-latest image being switched (some version bumps are done slightly differently)
- I fully support merging this PR after we have clarity in Stop testing on Python 3.7 #7585 (and I volunteer to resolve conflicts)
- I would rather see this with semver-minor and done against master. Again, I'm willing to perform the ceremony and resolve conflicts.
Python 3.7 EOL'ed mid-June. This PR
I think this needs to be done also for master, but for now I make only one PR to see what fails.