Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wildcard-variables] Add more explicit details on functions and records. #3802

Merged
merged 3 commits into from
May 15, 2024

Conversation

kallentu
Copy link
Member

Updates the spec from discussion on the two following issues: #3791 and #3790.

I wanted to update the spec to make some parts clearer to future readers.
Can you both take a look and let me know how I can wordsmith this better?

Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things then LGTM! Thanks for turning this into a real proposal!

working/wildcards/feature-specification.md Show resolved Hide resolved
working/wildcards/feature-specification.md Outdated Show resolved Hide resolved
working/wildcards/feature-specification.md Show resolved Hide resolved
working/wildcards/feature-specification.md Show resolved Hide resolved
@kallentu
Copy link
Member Author

Merging now, but open to following up if there are any more comments.

@kallentu kallentu merged commit 25a9cb3 into main May 15, 2024
3 checks passed
@kallentu kallentu deleted the wc-spec-update branch May 15, 2024 19:16
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a couple of comments.

working/wildcards/feature-specification.md Show resolved Hide resolved
working/wildcards/feature-specification.md Show resolved Hide resolved
working/wildcards/feature-specification.md Show resolved Hide resolved
working/wildcards/feature-specification.md Show resolved Hide resolved
working/wildcards/feature-specification.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants