Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wildcard-variables] Clarify wildcard behaviour on functions. #3813

Merged
merged 1 commit into from
May 17, 2024

Conversation

kallentu
Copy link
Member

This PR addresses Erik's comments in #3802 (review).


* Function parameters. This includes top-level functions, local functions,
function expressions ("lambdas"), instance methods, static methods,
constructors, etc. It includes all parameter kinds: simple, field formals,
and function-typed formals, etc.:
constructors, etc. It includes all parameter kinds, excluding named
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to explicitly call this out. Not sure if this is the best place to write this. I know it's in Initializing formals, but it'd be nice to restate here.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kallentu kallentu merged commit 482288a into main May 17, 2024
3 checks passed
@kallentu kallentu deleted the wc-comments branch May 17, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants