Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stats graph's tooltip layout of the metrics data #3771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fycdev
Copy link
Contributor

@fycdev fycdev commented Aug 5, 2022

Pull Request Form

Type of Pull Request

  • Bulk sentence upload

  • Related to a listed issue

  • Other
  • Adjust CSS of the tooltip in the Stats graph so that the metrics are laid out vertically and stays within the border.

Acknowledging contributors

@fycdev fycdev requested a review from a team as a code owner August 5, 2022 08:13
@fycdev fycdev requested review from data-sync-user and removed request for a team August 5, 2022 08:13
@mozgzh
Copy link
Contributor

mozgzh commented Aug 22, 2022

Thanks for the PR. I like the approach (keeping it simple). The only potential ssue is how tall the tooltip becomes with stacking. There's also an existing issue with how the date breaks (for EN its DD MONTH YYYY) which also adds the vertical height.

I think a solution could be to stop the date breaking, which would naturally add width and then changing from flex-direction: column; to flex-direction: row; to take advantage extra size. Let me know what you think!

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] amount of validated hours are displayed outside of the info field
2 participants