Fix horizontal overflow in stats tooltip #3817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The numbers corresponding to "Hours Recorded" and "Hours Validated" were positioned horizontally within the tooltip, causing the text to overflow outside of the tooltip bubble. We now use the default `display` styling for the containing <div>, which lays the statistics out vertically to avoid overflow.
|
Thanks for the PR! There's another PR #3771 that's related to this issue. I think the easiest solution is to ensure the tooltip container (with the white background) isn't restricted by width. If you want to give it a try, removing line 273 in index.css would fix the issue by allowing the parent div to wrap around the datapoints/date instead of forcing them to break. common-voice/web/src/components/index.css Line 273 in 441e644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
The numbers corresponding to "Hours Recorded" and "Hours Validated" were positioned horizontally within the tooltip, causing the text to overflow outside of the tooltip bubble. We now use the default
displaystyling for the containing<div>, which lays the metrics out vertically to avoid overflow.Type of Pull Request
Screenshots