Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Drop mobile pixel tests in TestHistoryMetrics.testEvents #20426

Merged
merged 1 commit into from
May 3, 2024
Merged

test: Drop mobile pixel tests in TestHistoryMetrics.testEvents #20426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/reference
Open in desktop
Submodule reference updated 2 files
+ − TestHistoryMetrics-testEvents-metrics-history-compressed-hour-mobile-pixels.png
+ − TestHistoryMetrics-testEvents-metrics-history-expanded-hour-mobile-pixels.png
5 changes: 3 additions & 2 deletions test/verify/check-metrics
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,16 +238,17 @@ class TestHistoryMetrics(testlib.MachineCase):
b.wait_in_text("#metrics-hour-1597662000000:not(.metrics-hour-compressed) .metrics-events-hour-header-expanded .spikes_count", "3 spikes")
b.wait_in_text("#metrics-hour-1597662000000:not(.metrics-hour-compressed) .metrics-events-hour-header-expanded .spikes_info", "1 Memory, 1 Disk I/O, 1 Network I/O")

# FIXME: mobile layout is racy in tests (only, not in reality), scrollIntoView() misplaces the menu bar
b.assert_pixels(".metrics", "metrics-history-expanded-hour", ignore=[".spikes_count"],
wait_after_layout_change=True)
skip_layouts=["mobile"], wait_after_layout_change=True)

b.click("#metrics-hour-1597662000000 button.metrics-events-expander")
b.wait_in_text("#metrics-hour-1597662000000.metrics-hour-compressed", "1:00")
b.wait_in_text("#metrics-hour-1597662000000.metrics-hour-compressed .spikes_count", "3 spikes")
b.wait_in_text("#metrics-hour-1597662000000.metrics-hour-compressed .spikes_info", "1 Memory, 1 Disk I/O, 1 Network I/O")

b.assert_pixels(".metrics", "metrics-history-compressed-hour", ignore=[".nodata"],
wait_after_layout_change=True)
skip_layouts=["mobile"], wait_after_layout_change=True)

# Check that events are not visible for compressed hours
b.wait_not_present("#metrics-hour-1597662000000 div.metrics-minute[data-minute='28'] .metrics-events")
Expand Down