test: Drop mobile pixel tests in TestHistoryMetrics.testEvents #20426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mobile pixel test is way too flaky (> 50% failure rate on our CI). scrollIntoViewIfNeeded() somehow misplaces the menu bar. This isn't a real problem, an interactive Firefox/Chromium works fine. Nobody has figured this out in two weeks, earlier attempts at fixing that (commits e700960 and 790b377) also weren't effective. Figuring this out is too much effort for too little benefit, and this flake breaks pretty much every PR. So disable the mobile pixel test. Fixes cockpit-project#20338
martinpitt
added
the
no-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile pixel test is way too flaky (> 50% failure rate on our CI). scrollIntoViewIfNeeded() somehow misplaces the menu bar. This isn't a real problem, an interactive Firefox/Chromium works fine.
Nobody has figured this out in two weeks, earlier attempts at fixing that (commits e700960 and 790b377) also weren't effective. Figuring this out is too much effort for too little benefit, and this flake breaks every PR. So disable the mobile pixel test.
Fixes #20338