Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Btrfs snapshot support #20234

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Btrfs snapshot support #20234

wants to merge 3 commits into from

Conversation

jelly
Copy link
Member

@jelly jelly commented Mar 28, 2024 •
edited

Show snapshots of a subvolume in the detail view.

image

@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Mar 28, 2024
@jelly jelly mentioned this pull request Apr 3, 2024
Open
@jelly
Copy link
Member Author

jelly commented Apr 3, 2024

@mvollmer I thought a bit on how we could implement filtering:

We could come up with a system where we don't have to hardcode the "filters" in but we could register filters for pages which want that.

register_filter(display_name, property_name)

This registers a filter which lives in pages.jsx, then we use these filter with property_name and filter_properties.

Alternatively, we just hardcode filters:

PAGE_FILTER_SNAPSHOT = 'snapshot'

Page/Card can have filter_properties which contains the key we are interested for with the value. State can come later.

I'm not thinking of introducing something like a filter component. But maybe it is interesting to have something usable.

@mvollmer
Copy link
Member

mvollmer commented Apr 4, 2024

@mvollmer I thought a bit on how we could implement filtering:

I think this is a bit too much machinery. Let's just do what we need, and nothing more.

@jelly
storaged: fix typo apges => pages
2c905e1
@jelly
btrfs: obtain subvolume snapshot information
a133855 
In btrfs a snapshot is a subvolume with a parent_uuid field filled in
with the uuid of the subvolume of which the snapshot is made.

Note that btrfs allows one to make a snapshot of a snapshot.
@jelly
Copy link
Member Author

jelly commented Apr 4, 2024

Alright, after the discussion today in standup:

  • First pass, show snapshots under a subvolume
  • Second pass, hide snapshots

@jelly
btrfs: show snapshots of a subvolume in the subvolume details page
ce13bed 
Register crossrefs for snapshots so they show under snapshots in the
detail page of a subvolume.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jelly @mvollmer