Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs snapshot support #20208

Open
jelly opened this issue Mar 20, 2024 · 2 comments
Open

btrfs snapshot support #20208

jelly opened this issue Mar 20, 2024 · 2 comments

Comments

@jelly
Copy link
Member

jelly commented Mar 20, 2024

Page: Storage

As a user I want to:

  • See what subvolumes are snapshots
  • Make a snapshot (optionally read only)
  • Delete a snapshot

To implemen this, modify our existing btrfs subvolume list and add the -u (uuid) and -q (parent_uuid) flags. An empty parent_uuid means that this is not a snapshot, if there is a uuid this is what I took the snapshot of. Of course you can take a snapshot of a snapshot...

btrfs subvolume list -apuq /
@garrett
Copy link
Member

garrett commented Mar 21, 2024

Do we even want to show snapshots as subvolumes? Cockpit Storage is for showing the storage of a system. Subvolumes included.

But snapshots aren't really subvolumes; they're usually frozen, read-only copies used as "backup" (real backup would not be on the same storage device), not really storage locations. Some people have a lot of snapshots, and it's kind of weird for us to show them, especially by default.

We probably need to not show it by default, and have a way to change filters. Then we could deal with snapshots more clearly.

Most people probably either don't use snapshots or they use them a lot (like a new snapshot per day), possibly even with a program that does this for them (like snapper). I suspect most people are probably not too much in the middle?

@jelly
Copy link
Member Author

jelly commented Apr 3, 2024

Made a draft PR here, with the goal to hide the snapshots on the over view and show them under a subvolume of which it is a snapshot:

#20234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants