test: Adjust stratis pool stop to stratis-cli 3.6.0
#19525
Conversation
martinpitt
added
release-blocker
The CLI changed in an incompatible way: Earlier versions just expected the pool name/UUID as positional argument, 3.6.0 now expects it through an `--uuid` or `--name` option.
martinpitt
force-pushed
the
stratis-cli
branch
from
69d76fe
to
5f14d48
Compare
martinpitt
changed the title
stratis pool stop to stratis-cli 3.6.0
|
Hmmkay, so stratis pool destroy did not change. How inconsistent.. |
martinpitt
removed
the
no-test
| @@ -36,12 +36,18 @@ class TestStorageStratis(storagelib.StorageCase): | |||
|
|
|||
| self.stratis_v2 = self.image.startswith("rhel-8") or self.image == "centos-8-stream" | |||
|
|
|||
| # the CLI changed in an incompatible way in Fedora 40 | |||
| if '--name' in exe("stratis pool stop --help"): | |||
There was a problem hiding this comment.
At first my eyes popped out of my head, but then I said "oh, it's only a test".
| @@ -36,12 +36,18 @@ class TestStorageStratis(storagelib.StorageCase): | |||
|
|
|||
| self.stratis_v2 = self.image.startswith("rhel-8") or self.image == "centos-8-stream" | |||
|
|
|||
| # the CLI changed in an incompatible way in Fedora 40 | |||
| if '--name' in exe("stratis pool stop --help"): | |||
| self.stop_type_opt = "--name" | |||
There was a problem hiding this comment.
Maybe you could turn this info pool_stop_cmd and have stratis pool stop or stratis pool stop --name in there, accordingly. Would be a nice factor-out?
There was a problem hiding this comment.
Yes, can do. I initially even had this, then changed it to this because I thought "oh, stratis pool destroy is going to need that, too", only to find out that it doesn't..
There was a problem hiding this comment.
On second thought, it may happen to other commands, this makes all PRs red, I actually find it nicer to read most of the command to see what's going on, and there's still so much other stuff to pilot. So I'll be so cheeky and land it as-is.
|
This landed with an incomplete test slate and is causing storage tests to fail in other PRs. See https://cockpit-logs.us-east-1.linodeobjects.com/pull-19527-20231025-171100-5b8a565c-arch-storage/log.html#65-2 for example. |
|
Argh, sorry! → PR #19531 |
The CLI changed in an incompatible way: Earlier versions just expected the pool name/UUID as positional argument, 3.6.0 now expects it through an
--uuidor--nameoption.This fixes the current rawhide failure.