Fix DOM nesting on the Storage page dialogs, enable DOM nesting errors #19509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
no-test
martinpitt
force-pushed
the
dom-nesting
branch
from
2a0e10f
to
f8bf272
Compare
|
After round 1: The ListingTable nesting fix caused some test regressions, selectors need to be adjusted. Some of the storage failures are also due to that, and some are independent problems. /expensive and /networking are green now. |
martinpitt
force-pushed
the
dom-nesting
branch
from
f8bf272
to
28ebf95
Compare
martinpitt
changed the title
martinpitt
force-pushed
the
dom-nesting
branch
from
28ebf95
to
6e7b9fa
Compare
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
martinpitt
force-pushed
the
dom-nesting
branch
from
6e7b9fa
to
94ae7a2
Compare
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
A `<table>` must not appear inside of a `<p>`, make them siblings instead.
A `<List>` block element must not appear inside a `<p>`, make them siblings instead.
RemovePassphraseField is already in a `<Form>`, so don't wrap the checkbox into a second one.
A ClipboardCopy is a block element (`<div>`) and thus cannot be put into a `<p>`. Make them silblings. To retain the current layout, turn the text into a simple span, so that the text and the ClipboardCopy still appear side by side.
Most errors were fixed recently. The remaining ones on the Storage page conflict with the ongoing page redesign, and may well already be fixed by it. Ignore them specifically for now. This will prevent introducing new DOM nesting errors in the future.
martinpitt
removed
the
no-test
martinpitt
force-pushed
the
dom-nesting
branch
from
94ae7a2
to
c71e152
Compare
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
cockpituous
reviewed
Oct 25, 2023
| <Checkbox id="force-remove-passphrase" | ||
| isChecked={val !== false} | ||
| label={_("Confirm removal with an alternate passphrase")} | ||
| onChange={(_event, checked) => change(checked ? "" : false)} |
There was a problem hiding this comment.
This added line is not executed by any test. Details
|
Rawhide failure is unrelated, see PR #19525 |
mvollmer
reviewed
Oct 26, 2023
mvollmer
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the following cases in main:
storage:
expensive/networking already got fixed in #19520:
/other is okay.
Builds on top of: