Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ColumnarDataSource.inspection_policy #13439

Open
wants to merge 1 commit into
base: branch-3.5
Choose a base branch
from

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Oct 13, 2023

Early work in progress attempt to unify behavior of selections and inspections.

fixes #13388

@mattpap mattpap added this to the 3.4 milestone Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (e61219b) to head (f4306ad).
Report is 6 commits behind head on branch-3.5.

❗ Current head f4306ad differs from pull request most recent head 7608549. Consider uploading reports for the commit 7608549 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.5   #13439      +/-   ##
==============================================
+ Coverage       91.57%   92.58%   +1.01%     
==============================================
  Files             326      325       -1     
  Lines           20737    20730       -7     
==============================================
+ Hits            18990    19193     +203     
+ Misses           1747     1537     -210     

@mattpap mattpap force-pushed the mattpap/13388_inspection_policy branch from e61b968 to 77cf1cf Compare October 13, 2023 19:22
@mattpap mattpap force-pushed the mattpap/13388_inspection_policy branch 3 times, most recently from a5e4d43 to f4306ad Compare February 23, 2024 08:49
@mattpap mattpap modified the milestones: 3.4, 3.5 Feb 28, 2024
@mattpap mattpap changed the base branch from branch-3.4 to branch-3.5 March 14, 2024 16:52
@mattpap mattpap force-pushed the mattpap/13388_inspection_policy branch from f4306ad to 7608549 Compare April 12, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TapTool inspection doesn't find indices when used on CDSView
1 participant