Fix computation of image indices for inverted ranges #13557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13557 +/- ##
===========================================
Coverage 92.57% 92.57%
===========================================
Files 322 322
Lines 20461 20461
===========================================
Hits 18941 18941
Misses 1520 1520 |
bryevdv
approved these changes
Nov 30, 2023
mattpap
commented
Dec 1, 2023
mattpap
force-pushed
the
mattpap/13555_image_index_inverted
branch
from
d37e65b
to
e2c2f62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes (includes) handling of image indices in
Selection. This wasn't noticed before, because with inspections go through a different code path, which persists those indices. I will look more into this in PR #13439 or its follow-up.fixes #13555