Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize sub-plot API and add documentation #13346

Closed
wants to merge 2 commits into from

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Aug 23, 2023

Early work in progress. First I need to finalize PR #12068 and then I will complete the documentation here.

@mattpap mattpap added this to the 3.3 milestone Aug 23, 2023
@mattpap mattpap force-pushed the mattpap/12073_subcoordinates branch from 863bc7e to 7b7a07e Compare August 23, 2023 09:22
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.45%. Comparing base (ed5f22b) to head (7b7a07e).
Report is 296 commits behind head on branch-3.5.

Additional details and impacted files
@@             Coverage Diff             @@
##           branch-3.5   #13346   +/-   ##
===========================================
  Coverage       92.45%   92.45%           
===========================================
  Files             315      315           
  Lines           20169    20173    +4     
===========================================
+ Hits            18647    18651    +4     
  Misses           1522     1522           

@bryevdv
Copy link
Member

bryevdv commented Aug 23, 2023

@mattpap Is this where you want to hash out x_source / x_target? I do think reusing "source" in this different context is unadvised.

@mattpap mattpap mentioned this pull request Sep 18, 2023
1 task
@mattpap mattpap modified the milestones: 3.3, 3.4 Oct 4, 2023
@mattpap mattpap changed the base branch from branch-3.3 to branch-3.4 October 10, 2023 12:45
@mattpap mattpap modified the milestones: 3.4, 3.5 Feb 28, 2024
@mattpap mattpap changed the base branch from branch-3.4 to branch-3.5 March 14, 2024 16:52
@mattpap mattpap removed this from the 3.5 milestone May 13, 2024
@mattpap
Copy link
Contributor Author

mattpap commented May 13, 2024

Closing this in favour of changes in PR #13344.

@mattpap mattpap closed this May 13, 2024
@mattpap mattpap deleted the mattpap/12073_subcoordinates branch May 13, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user guide section about sub-coordinates/subplots
2 participants