-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a variant of ridgeplot example that uses sub-coordinates #12068
Conversation
This is great, but there is a little more updating required. This example is also used here: https://docs.bokeh.org/en/latest/docs/user_guide/categorical.html#categorical-offsets as a demonstration of categorical offsets. We shouldn't use the same example in two different ways in different places. (If we want to compare/contrast methods it should be explicit and side by side) cc @tcmetzger for thoughts on how to organize. Some comments:
|
That's a good point! I agree that we shouldn't use something that looks the same to illustrate two different concepts in two different places. I see basically the following options:
It sounds to me like using sub-coordinates is now the definitive way to go for ridge plots, so that means we should probably look at option one: creating a new example to serve as an illustration of categorical offsets. Do you have any ideas what that could be? If not, we can also just leave it at one example (the current fruit count example) in the user guide's 'categorical offsets' section and just not have a "more sophisticated example". |
981facc
to
f315ddf
Compare
Codecov Report
@@ Coverage Diff @@
## branch-3.3 #12068 +/- ##
===========================================
Coverage 92.45% 92.45%
===========================================
Files 317 317
Lines 20268 20268
===========================================
Hits 18738 18738
Misses 1530 1530 |
f315ddf
to
7908b82
Compare
7908b82
to
7ce25ed
Compare
I took a different approach with this. I added a new category to |
@mattpap There is intended to be a 1-1 correspondence between Edit: Here is the current chapter/subchapter hierarchy with the top level directories noted: Basic plotting
Appearance Topic guides
I could imaging Basic Plotting -> Sub-coordinates as making sense, or it could potentially go under Appearance if we wanted to broaden the scope of that chapter (cc @tcmetzger) but if you want to punt on this for now just move it to one of the grab-bag dirs and open an issue to discuss future docs work around it. |
@mattpap for expediency I think the simplest thing to do is to move the example to |
3c10e51
to
60e5110
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of wording suggestions
Keeps the original look, but allows to preserve actual data (see
data (x, y)
in the tooltip).