Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: disable asan for sha256_sse4 with clang and -O0 #30097

Merged
merged 1 commit into from May 16, 2024

Conversation

theuni
Copy link
Member

@theuni theuni commented May 13, 2024

Clang is unable to compile the Transform function for that combination of options.

Fixes #29801.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 13, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK achow101
Concept ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@theuni
Copy link
Member Author

theuni commented May 13, 2024

Ping @achow101. Sorry this took so long!

@fanquake
Copy link
Member

Concept ACK - Think I prefer fixing this inline, than in global flags / build. I guess we didn't end up making an issue upstream (https://github.com/llvm/llvm-project/issues)? If there is something to link to, would be good to add it here.

@fanquake
Copy link
Member

Checked this (./configure --enable-debug --with-sanitizers=address CC=clang CXX=clang++) works with Ubuntu clang version 18.1.3 (1) on x86_64.

@theuni
Copy link
Member Author

theuni commented May 14, 2024

Concept ACK - Think I prefer fixing this inline, than in global flags / build. I guess we didn't end up making an issue upstream (https://github.com/llvm/llvm-project/issues)? If there is something to link to, would be good to add it here.

Upstream issue filed here: llvm/llvm-project#92182

@fanquake
Copy link
Member

Upstream issue filed here: llvm/llvm-project#92182

Thanks. Could you like to that thread from the comment added to the source, then this is probably good to go.

Clang is unable to compile the Transform function for that combination of
options.
@theuni
Copy link
Member Author

theuni commented May 15, 2024

Could you like to that thread from the comment added to the source, then this is probably good to go.

Done

@achow101
Copy link
Member

ACK 141df0a

It builds 🎉

@DrahtBot DrahtBot requested a review from fanquake May 15, 2024 18:33
@fanquake fanquake merged commit ae2658c into bitcoin:master May 16, 2024
16 checks passed
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request May 16, 2024
Clang is unable to compile the Transform function for that combination of
options.

Github-Pull: bitcoin#30097
Rebased-From: 141df0a
@fanquake
Copy link
Member

Backported to 27.x in #30092.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure with -O0 + -fsanitize=address due to inline asm
4 participants