Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x] Backports and rc1 #30092

Open
wants to merge 11 commits into
base: 27.x
Choose a base branch
from
Open

[27.x] Backports and rc1 #30092

wants to merge 11 commits into from

Conversation

furszy and others added 2 commits May 13, 2024 11:57
Fixes: bitcoin#809

Previously it was possible through the GUI to enter an IP address:port
into the "Proxy IP" configuration box. After the node was restarted the
errant setting would prevent the node starting back up until manually
removed from settings.json.

Github-Pull: bitcoin-core/gui#813
Rebased-From: 10c5275
@fanquake fanquake added this to the 27.1 milestone May 13, 2024
@DrahtBot
Copy link
Contributor

DrahtBot commented May 13, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
Stale ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Without explicitly declaring the move, these UniValues get copied,
causing increased memory usage. Fix this by explicitly moving the
UniValue objects.

Used by `rest_block` and `getblock` RPC.

Github-Pull: bitcoin#30094
Rebased-From: b77bad3
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9867e72, I have reproduced backporting locally.

@jonatack
Copy link
Contributor

Propose #30085 if merged in time.

Clang is unable to compile the Transform function for that combination of
options.

Github-Pull: bitcoin#30097
Rebased-From: 141df0a
Addnode (manual) peers connected to us via the cjdns network are currently not
detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false.

This causes the following issues:

- RPC `getaddednodeinfo` incorrectly shows them as not connected

- CConnman::ThreadOpenAddedConnections() continually retries to connect them

Github-Pull: bitcoin#30085
Rebased-From: 684da97
@fanquake fanquake marked this pull request as ready for review May 22, 2024 10:00
@fanquake fanquake changed the title [27.x] Backports and probably finalize [27.x] Backports and rc1 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants