Added significant amount of validation to components #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focus as on preventing lazy errors, where the primary issue is an incorrect configuration, but where the runtime error only occurs once the system is up and running, resulting in difficult to diagnose errors. The two ways this was accomplished by: - Add partyId validation whereever possible. - Add `Objects.requireNonNull` checks in component constructors. Additionally: - Added improved dianostics for failing futures in MASCOT `TestRuntime`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #417, by preventing lazy errors, where the primary issue is an incorrect configuration, but where the runtime error only occurs once the computation is running, resulting in difficult to diagnose errors.
The two ways this was accomplished by:
Objects.requireNonNullchecks in component constructors.Additionally:
TestRuntime.