Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node identifier validation #417

Closed
no-longer-human opened this issue Mar 27, 2024 · 1 comment
Closed

Node identifier validation #417

no-longer-human opened this issue Mar 27, 2024 · 1 comment

Comments

@no-longer-human
Copy link
Contributor

Node identifiers are one-indexed, which is different from the usual 0-indexing used by Java and most libraries. In many cases supplying 0 to a function or component constructor that expects [1,N] will result in an unexplained hang during execution.

I propose to add more validation to catch these kinds of issues earlier.

Feel free to assign me to this issue.
@no-longer-human no-longer-human mentioned this issue Apr 2, 2024
Merged
@no-longer-human
Copy link
Contributor Author

Fixed by #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@no-longer-human