Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): fix infinite loop in self-managed tooltips #4269

Merged
merged 7 commits into from
Apr 29, 2024
Merged

fix(tooltip): fix infinite loop in self-managed tooltips #4269

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a89cbb1
fix(tooltip): fix infinite loop in self-managed tooltips
Apr 15, 2024
3469d6d
Merge branch 'main' into rocss/self-managed-tooltip-infinite-loop
Rocss Apr 17, 2024
70d6f97
chore: return null instead of document when no trigger is found
Apr 25, 2024
114c1d5
Merge branch 'main' into rocss/self-managed-tooltip-infinite-loop
Rocss Apr 25, 2024
1f913a8
chore: add a unit test to verify that event listeners are no longer a…
Apr 26, 2024
5314015
chore: update tests to verify against triggerElement
Apr 29, 2024
b90a39c
Merge branch 'main' into rocss/self-managed-tooltip-infinite-loop
Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/tooltip/src/Tooltip.ts
View file
Open in desktop
Expand Up @@ -209,8 +209,8 @@ export class Tooltip extends SpectrumElement {
// Resolve the parent element of the assigned slot (if one exists) or of the Tooltip.
let start: HTMLElement = this.assignedSlot || this;
let root = start.getRootNode();
if (window.__swc.DEBUG) {
if (root === document) {
if (root === document) {
if (window.__swc.DEBUG) {
window.__swc.warn(
this,
`Self managed <${this.localName}> elements walk up the composed tree to acquire a trigger element. No trigger element was found before the document.`,
Expand All @@ -219,8 +219,8 @@ export class Tooltip extends SpectrumElement {
level: 'high',
}
);
return root as HTMLElement;
}
return root as HTMLElement;
}
let triggerElement = (start.parentElement ||
(root as ShadowRoot).host ||
Expand All @@ -231,8 +231,8 @@ export class Tooltip extends SpectrumElement {
triggerElement.assignedSlot || (triggerElement as HTMLElement);
root = start.getRootNode();
/* c8 ignore next 13 */
if (window.__swc.DEBUG) {
if (root === document) {
if (root === document) {
if (window.__swc.DEBUG) {
window.__swc.warn(
this,
`Self managed <${this.localName}> elements walk up the composed tree to acquire a trigger element. No trigger element was found before the document.`,
Expand All @@ -241,8 +241,8 @@ export class Tooltip extends SpectrumElement {
level: 'high',
}
);
return root as HTMLElement;
}
return root as HTMLElement;
}
triggerElement = (start.parentElement ||
(root as ShadowRoot).host ||
Expand Down