fix(tooltip): fix infinite loop in self-managed tooltips #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Tachometer resultsChromeaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
picker permalinkbasic-test
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
Firefoxaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
picker permalinkbasic-test
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
|
Westbrook
reviewed
Apr 22, 2024
|
@Westbrook As it is right now it does bind event listeners on the document. |
|
Westbrook
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Do we have tests that prove that if it finds document it doesn't bind listeners? A Tooltip in this situation should not work in any way, it should only dispatch the Dev Mode warning.
If not, we can land this on the presumption it works, as it seems to not be working for you otherwise.
…ttached to document
|
@Westbrook I added a unit test which fails before this change. Let me know if this would be enough in this scenario, or else I'm happy to implement other checks as well! |
Westbrook
reviewed
Apr 29, 2024
| ); | ||
|
|
||
| await elementUpdated(el); | ||
| expect(documentEventsSpy.callCount).to.equal(0); |
There was a problem hiding this comment.
Can we confirm it doesn't attach to anything else, too?
Suggested change
| expect(documentEventsSpy.callCount).to.equal(0); | |
| expect(documentEventsSpy.callCount).to.equal(0); | |
| expect(el.overlayElement?.triggerElement).to.be.null; |
Westbrook
reviewed
Apr 29, 2024
Westbrook
approved these changes
Apr 29, 2024
Thank you, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reordering some
ifstatements to make sure a trigger is always returned for self-managed tooltips.Related issue(s)
Motivation and context
Fixes a bug which reproduces only when NOT in DEBUG mode. See details in the issue above.
Not sure how to add a unit test for this, since
triggerElementis private and I can not check it from outside.How has this been tested?
self-managedstory and replacedsp-action-buttonwith adivdocumentself-managedstory and replacedsp-action-buttonwith adivdocumentScreenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.