removal: darkest theme references #4177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch previewVisual regression test resultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
|
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-menu permalinktest-basic
card permalinktest-basic
combobox permalinkbasic-test
light-dom-test permalink
illustrated-message permalinktest-basic
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
Firefoxaction-bar permalinkbasic-test
action-menu permalinktest-basic
card permalinktest-basic
combobox permalinkbasic-test
light-dom-test permalink
illustrated-message permalinktest-basic
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
|
Rajdeepc
changed the title
Westbrook
reviewed
Apr 25, 2024
| @@ -218,7 +218,7 @@ jobs: | |||
| keys: | |||
| - v2-golden-images-<< pipeline.parameters.current_golden_images_hash >>-hcm- | |||
| - v2-golden-images-main-hcm- | |||
| - v2-golden-images-main-classic-lightest-medium-ltr- | |||
| - v2-golden-images-main-classic-light-medium-ltr- | |||
There was a problem hiding this comment.
I think we can remove this all together. It was to give a backstop when we first added HCM support.
| @@ -1028,7 +1028,6 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline | |||
| - **action-menu:** update spectrum css input ([62a5065](https://github.com/adobe/spectrum-web-components/commit/62a50651a3c797598f8d76330e87f2824cdabbc5)) | |||
| - **actionbar:** add actionbar component package ([36dd7e9](https://github.com/adobe/spectrum-web-components/commit/36dd7e943a8b825b947f0053ddbe31b69ca27062)) | |||
| - **actionbar:** update spectrum css input ([8c888aa](https://github.com/adobe/spectrum-web-components/commit/8c888aa883490fe8e6a070f799095284128a609a)) | |||
| - add "darkest" theme styles ([fe38025](https://github.com/adobe/spectrum-web-components/commit/fe38025d2b631f07834789c936efe7ffcbc1a628)) | |||
There was a problem hiding this comment.
This is a changelog, it shouldn't be edited.
| @@ -69,6 +69,10 @@ governing permissions and limitations under the License. | |||
| --spectrum-card-selected-background-opacity: 0.1; | |||
| } | |||
|
|
|||
| :host .spectrum--darkest { | |||
There was a problem hiding this comment.
This is wrong. Where does it come from?
| @@ -10,5 +10,4 @@ OF ANY KIND, either express or implied. See the License for the specific languag | |||
| governing permissions and limitations under the License. | |||
| */ | |||
|
|
|||
| import '@spectrum-web-components/theme/theme-lightest.js'; | |||
| import '@spectrum-web-components/theme/scale-medium.js'; | |||
There was a problem hiding this comment.
I'm not 100% sure how this is used anymore, but this should likely be large and dark as seen in getting-started.md or removed all together. 🤔
| @@ -205,7 +205,7 @@ export const regressVisuals = async (name: string, stories: TestsType) => { | |||
| if (color && scale && dir) { | |||
| test(stories, name, color, scale, dir); | |||
| } else { | |||
| const colors: Color[] = ['lightest', 'light', 'dark', 'darkest']; | |||
| const colors: Color[] = ['light', 'dark']; | |||
There was a problem hiding this comment.
In other places you don't remove darkest?
| @@ -445,8 +445,6 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline | |||
|
|
|||
| ### Features | |||
|
|
|||
| - add "darkest" theme styles ([fe38025](https://github.com/adobe/spectrum-web-components/commit/fe38025)) | |||
There was a problem hiding this comment.
Please don't edit changelogs.
| @@ -433,8 +433,6 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline | |||
|
|
|||
| ### Features | |||
|
|
|||
| - add "darkest" theme styles ([fe38025](https://github.com/adobe/spectrum-web-components/commit/fe38025)) | |||
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed
darkesttheme and its references from the SWC project. This is a first step towards deprecating thelightest&darkestthemes and its files from the project. We will be continuing with onlylightanddarkvariants ofspectrumandexpressandspectrum-2systems.Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.