removal: lightest theme references #4175

Rajdeepc · 2024-03-14T06:28:15Z

Description

Removed lightest theme and its references from the SWC project. This is a first step towards deprecating the lightest & darkest themes and its files from the project. We will be continuing with only light and dark variants of spectrum and express and spectrum-2 systems.

Related issue(s)

Motivation and context

How has this been tested?

Test case 1
1. Go here
2. Do this
Test case 2
1. Go here
2. Do this

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions · 2024-03-14T06:30:43Z

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions · 2024-03-14T06:32:37Z

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.97	0.97	0.97
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	242.623 kB	228.818 kB	228.544 kB 🏆
Scripts	61.377 kB	54.688 kB	54.429 kB 🏆
Stylesheet	48.716 kB	42.225 kB 🏆	42.243 kB
Document	5.818 kB	5.175 kB	5.16 kB 🏆
Third Party	126.712 kB	126.73 kB	126.712 kB

Request Count

Category	Latest	Main	Branch
Total	43	43	43
Scripts	35	35	35
Stylesheet	5	5	5
Document	1	1	1
Third Party	2	2	2

github-actions · 2024-03-14T06:57:03Z

Tachometer results

Chrome

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	446 kB	68.91ms - 71.13ms	-	unsure 🔍 -3% - +2% -2.08ms - +1.23ms
branch	437 kB	69.22ms - 71.67ms	unsure 🔍 -2% - +3% -1.23ms - +2.08ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	607 kB	161.66ms - 164.76ms	-	unsure 🔍 -3% - +0% -4.69ms - +0.16ms
branch	599 kB	163.61ms - 167.35ms	unsure 🔍 -0% - +3% -0.16ms - +4.69ms	-

card permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	465 kB	58.75ms - 59.69ms	-	unsure 🔍 -1% - +1% -0.69ms - +0.57ms
branch	456 kB	58.86ms - 59.70ms	unsure 🔍 -1% - +1% -0.57ms - +0.69ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	668 kB	35.93ms - 36.66ms	-	unsure 🔍 -2% - +2% -0.70ms - +0.56ms
branch	659 kB	35.85ms - 36.88ms	unsure 🔍 -2% - +2% -0.56ms - +0.70ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	668 kB	403.10ms - 412.86ms	-	unsure 🔍 -2% - +1% -8.46ms - +4.02ms
branch	660 kB	406.31ms - 414.09ms	unsure 🔍 -1% - +2% -4.02ms - +8.46ms	-

illustrated-message permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	367 kB	30.93ms - 31.18ms	-	unsure 🔍 -0% - +1% -0.09ms - +0.28ms
branch	358 kB	30.82ms - 31.09ms	unsure 🔍 -1% - +0% -0.28ms - +0.09ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	437 kB	208.88ms - 212.90ms	-	unsure 🔍 -2% - +1% -4.50ms - +1.38ms
branch	428 kB	210.31ms - 214.60ms	unsure 🔍 -1% - +2% -1.38ms - +4.50ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	638 kB	462.83ms - 466.35ms	-	unsure 🔍 -0% - +1% -2.27ms - +2.96ms
branch	634 kB	462.31ms - 466.19ms	unsure 🔍 -1% - +0% -2.96ms - +2.27ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	748 kB	35.18ms - 35.64ms	-	unsure 🔍 -2% - +0% -0.61ms - +0.06ms
branch	735 kB	35.44ms - 35.93ms	unsure 🔍 -0% - +2% -0.06ms - +0.61ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	720 kB	348.12ms - 352.28ms	-	unsure 🔍 -0% - +1% -1.59ms - +4.21ms
branch	711 kB	346.87ms - 350.91ms	unsure 🔍 -1% - +0% -4.21ms - +1.59ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	720 kB	52.05ms - 53.02ms	-	unsure 🔍 -1% - +2% -0.71ms - +0.84ms
branch	712 kB	51.86ms - 53.08ms	unsure 🔍 -2% - +1% -0.84ms - +0.71ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	473 kB	567.56ms - 576.08ms	-	unsure 🔍 -1% - +1% -5.02ms - +7.19ms
branch	465 kB	566.36ms - 575.10ms	unsure 🔍 -1% - +1% -7.19ms - +5.02ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	345 kB	20.20ms - 20.34ms	-	unsure 🔍 -1% - +0% -0.14ms - +0.07ms
branch	336 kB	20.23ms - 20.38ms	unsure 🔍 -0% - +1% -0.07ms - +0.14ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	441 kB	104.76ms - 106.95ms	-	unsure 🔍 -1% - +2% -1.06ms - +1.81ms
branch	432 kB	104.55ms - 106.40ms	unsure 🔍 -2% - +1% -1.81ms - +1.06ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	680 kB	1864.99ms - 1867.99ms	-	unsure 🔍 -0% - +0% -1.39ms - +2.70ms
branch	673 kB	1864.44ms - 1867.22ms	unsure 🔍 -0% - +0% -2.70ms - +1.39ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	613 kB	60.76ms - 62.03ms	-	unsure 🔍 -3% - +1% -2.11ms - +0.39ms
branch	605 kB	61.18ms - 63.33ms	unsure 🔍 -1% - +3% -0.39ms - +2.11ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	593 kB	34.12ms - 35.25ms	-	slower ❌ 0% - 4% 0.05ms - 1.27ms
branch	585 kB	33.80ms - 34.26ms	faster ✔ 0% - 4% 0.05ms - 1.27ms	-

Firefox

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	446 kB	142.05ms - 149.07ms	-	unsure 🔍 -2% - +5% -2.25ms - +6.89ms
branch	437 kB	140.32ms - 146.16ms	unsure 🔍 -5% - +2% -6.89ms - +2.25ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	607 kB	317.22ms - 329.66ms	-	unsure 🔍 -2% - +2% -7.29ms - +7.97ms
branch	599 kB	318.68ms - 327.52ms	unsure 🔍 -2% - +2% -7.97ms - +7.29ms	-

card permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	465 kB	108.15ms - 115.73ms	-	unsure 🔍 -2% - +7% -2.60ms - +7.36ms
branch	456 kB	106.32ms - 112.80ms	unsure 🔍 -7% - +2% -7.36ms - +2.60ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	668 kB	65.18ms - 71.86ms	-	slower ❌ 10% - 22% 6.05ms - 12.91ms
branch	659 kB	58.28ms - 59.80ms	faster ✔ 9% - 18% 6.05ms - 12.91ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	668 kB	719.53ms - 738.71ms	-	slower ❌ 3% - 7% 23.90ms - 45.78ms
branch	660 kB	689.01ms - 699.55ms	faster ✔ 3% - 6% 23.90ms - 45.78ms	-

illustrated-message permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	367 kB	46.95ms - 50.97ms	-	unsure 🔍 -5% - +8% -2.36ms - +3.92ms
branch	358 kB	45.77ms - 50.59ms	unsure 🔍 -8% - +5% -3.92ms - +2.36ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	437 kB	401.79ms - 414.93ms	-	unsure 🔍 -2% - +3% -6.88ms - +10.76ms
branch	428 kB	400.54ms - 412.30ms	unsure 🔍 -3% - +2% -10.76ms - +6.88ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	726 kB	722.90ms - 747.86ms	-	slower ❌ 2% - 6% 15.56ms - 44.32ms
branch	718 kB	698.29ms - 712.59ms	faster ✔ 2% - 6% 15.56ms - 44.32ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	729 kB	71.79ms - 72.77ms	-	unsure 🔍 -3% - +0% -1.90ms - +0.26ms
branch	720 kB	72.14ms - 74.06ms	unsure 🔍 -0% - +3% -0.26ms - +1.90ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	720 kB	647.79ms - 660.17ms	-	slower ❌ 4% - 7% 23.72ms - 43.24ms
branch	711 kB	612.96ms - 628.04ms	faster ✔ 4% - 7% 23.72ms - 43.24ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	720 kB	117.55ms - 125.89ms	-	slower ❌ 7% - 15% 7.68ms - 16.32ms
branch	712 kB	108.57ms - 110.87ms	faster ✔ 7% - 13% 7.68ms - 16.32ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	473 kB	996.48ms - 1021.80ms	-	unsure 🔍 -1% - +2% -9.43ms - +20.07ms
branch	465 kB	996.25ms - 1011.39ms	unsure 🔍 -2% - +1% -20.07ms - +9.43ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	345 kB	40.37ms - 44.11ms	-	unsure 🔍 -9% - +4% -4.05ms - +1.77ms
branch	336 kB	41.15ms - 45.61ms	unsure 🔍 -4% - +10% -1.77ms - +4.05ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	441 kB	199.19ms - 205.81ms	-	unsure 🔍 -3% - +2% -5.82ms - +4.98ms
branch	432 kB	198.65ms - 207.19ms	unsure 🔍 -2% - +3% -4.98ms - +5.82ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	680 kB	1599.19ms - 1605.17ms	-	faster ✔ 0% - 1% 2.15ms - 11.85ms
branch	673 kB	1605.36ms - 1613.00ms	slower ❌ 0% - 1% 2.15ms - 11.85ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	613 kB	208.30ms - 216.54ms	-	slower ❌ 0% - 5% 0.33ms - 10.83ms
branch	605 kB	203.58ms - 210.10ms	faster ✔ 0% - 5% 0.33ms - 10.83ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	593 kB	71.79ms - 75.49ms	-	faster ✔ 15% - 22% 13.09ms - 20.51ms
branch	585 kB	87.22ms - 93.66ms	slower ❌ 17% - 28% 13.09ms - 20.51ms	-

Westbrook

Sync with the notes in #4177 or possibly merge the two PRs as they're namely the same work in different places.

fix: removed lightest references from the project

3fcb6b7

Rajdeepc added the deprecation label Mar 14, 2024

fix: updated tests

faae836

Rajdeepc changed the title ~~deprecation: removed lightest theme references from the project~~ deprecation: removed all lightest theme references Mar 14, 2024

Rajdeepc changed the title ~~deprecation: removed all lightest theme references~~ deprecation: lightest theme references Mar 14, 2024

Westbrook marked this pull request as draft March 14, 2024 13:59

Rajdeepc changed the title ~~deprecation: lightest theme references~~ removal: lightest theme references Mar 15, 2024

Westbrook reviewed Apr 25, 2024

View reviewed changes

removal: lightest theme references #4175

Are you sure you want to change the base?

removal: lightest theme references #4175

Conversation

Rajdeepc commented Mar 14, 2024 • edited

Description

Related issue(s)

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Checklist

Best practices

github-actions bot commented Mar 14, 2024

Branch preview

github-actions bot commented Mar 14, 2024 • edited

Lighthouse scores

Transfer Size

Request Count

github-actions bot commented Mar 14, 2024 • edited

Tachometer results

action-bar permalink

basic-test

action-menu permalink

test-basic

card permalink

test-basic

combobox permalink

basic-test

light-dom-test permalink

illustrated-message permalink

test-basic

menu permalink

test-basic

overlay permalink

basic-test

directive-test permalink

element-test permalink

lazy-test permalink

picker permalink

basic-test

popover permalink

test-basic

slider permalink

test-basic

split-button permalink

basic-test

tooltip permalink

test-basic

test-directive permalink

action-bar permalink

basic-test

action-menu permalink

test-basic

card permalink

test-basic

combobox permalink

basic-test

light-dom-test permalink

illustrated-message permalink

test-basic

menu permalink

test-basic

overlay permalink

basic-test

directive-test permalink

element-test permalink

lazy-test permalink

picker permalink

basic-test

popover permalink

test-basic

slider permalink

test-basic

split-button permalink

basic-test

tooltip permalink

test-basic

test-directive permalink

Westbrook left a comment

Rajdeepc commented Mar 14, 2024 •

edited

github-actions bot commented Mar 14, 2024 •

edited

github-actions bot commented Mar 14, 2024 •

edited