-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor logic to prevent breaking changes in useToastState #6270
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fbd9172
Refactor logic to prevent breaking changes in useToastState
LFDanLu b83af04
Merge branch 'main' into toast_state_take_2
snowystinger 6ffd4f5
added more tests and fixing a bug they caught
ktabors 1e7184a
Merge branch 'toast_state_take_2' of github.com:adobe/react-spectrum …
ktabors fbde481
Fixed the other bug found by new tests
ktabors 344b124
fix toast visual insertion so it inserts at the bottom
LFDanLu a69022e
remove uneeded key and handle case where a user just calls remove
LFDanLu d812221
tentative change to readd exiting to toasts that are shifted out of t…
LFDanLu 2edead2
fix so that a toast that is removed but not closed doesnt get removed…
LFDanLu 02cf240
Merge branch 'main' of github.com:adobe/react-spectrum into toast_sta…
LFDanLu 6ca5d84
Merge branch 'main' into toast_state_take_2
LFDanLu ead9919
Merge branch 'main' into toast_state_take_2
LFDanLu 735fcab
add test to make sure order of toast doesnt change on close
LFDanLu 9026e59
Merge branch 'main' into toast_state_take_2
devongovett File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change or was
this.queue.unshift(toast);
a bug we hadn't found?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts the logic to what is currently released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I just remembered that and was coming back to delete it, but you responded.