Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logic to prevent breaking changes in useToastState #6270

Merged
merged 14 commits into from
Apr 30, 2024
Merged

Refactor logic to prevent breaking changes in useToastState #6270

merged 14 commits into from
Apr 30, 2024

Commits on Apr 26, 2024

  1. Refactor logic to prevent breaking changes in useToastState

    @LFDanLu
    LFDanLu committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fbd9172 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into toast_state_take_2

    @snowystinger
    snowystinger committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b83af04 View commit details
    Browse the repository at this point in the history

  3. added more tests and fixing a bug they caught

    @ktabors
    ktabors committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6ffd4f5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'toast_state_take_2' of github.com:adobe/react-spectrum … 

    …into toast_state_take_2
    @ktabors
    ktabors committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1e7184a View commit details
    Browse the repository at this point in the history

  5. Fixed the other bug found by new tests

    @ktabors
    ktabors committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fbde481 View commit details
    Browse the repository at this point in the history

  6. fix toast visual insertion so it inserts at the bottom

    @LFDanLu
    LFDanLu committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    344b124 View commit details
    Browse the repository at this point in the history

  7. remove uneeded key and handle case where a user just calls remove

    @LFDanLu
    LFDanLu committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a69022e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. tentative change to readd exiting to toasts that are shifted out of t… 

    …he visibleToast list due to a higher priority toast being added
    @LFDanLu
    LFDanLu committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d812221 View commit details
    Browse the repository at this point in the history

  2. fix so that a toast that is removed but not closed doesnt get removed… 

    … from the queue

this mimics the exitAnimation call to close that RSP toast does
    @LFDanLu
    LFDanLu committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2edead2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:adobe/react-spectrum into toast_sta… 

    …te_take_2
    @LFDanLu
    LFDanLu committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    02cf240 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'main' into toast_state_take_2

    @LFDanLu
    LFDanLu committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6ca5d84 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into toast_state_take_2

    @LFDanLu
    LFDanLu committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ead9919 View commit details
    Browse the repository at this point in the history

  3. add test to make sure order of toast doesnt change on close

    @LFDanLu
    LFDanLu committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    735fcab View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into toast_state_take_2

    @devongovett
    devongovett committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9026e59 View commit details
    Browse the repository at this point in the history