Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Aria pattern utils #6208

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

WIP Aria pattern utils #6208

wants to merge 18 commits into from

Commits on Apr 23, 2024

  1. rough progress in refactoring api and testing timers

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ca702b9 View commit details
    Browse the repository at this point in the history

  2. update RAC select tests to use the select util

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b0ea3a6 View commit details
    Browse the repository at this point in the history

  3. fix edge cases and add flows for different interaction patterns

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a7c832d View commit details
    Browse the repository at this point in the history

  4. adding sections and removing valueElement, wrapping up final conversi… 

    …ons for Picker tests

only modified some of the Picker tests to leverage the utils where I deemed appropriate. Mainly where selection/opening of the Picker wasnt the main focus of the test or if the test itself wasnt checking stuff about the item nodes themselves.
    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    faae16e View commit details
    Browse the repository at this point in the history

  5. add initial table util scaffolding 

    mostly from old PR, adapted to fit the new api
    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    65680b0 View commit details
    Browse the repository at this point in the history

  6. testing against the RAC tests/React 16/17 

    had to add an increased test timeout for React 16 tests
    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fd842c6 View commit details
    Browse the repository at this point in the history

  7. more testing of long press, add findCell/findRow

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    287ce79 View commit details
    Browse the repository at this point in the history

  8. test all the different interaction types 

    the keyboard sort change util function isnt working properly, investigating. The focus isnt being restored to the right place
    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6cf55db View commit details
    Browse the repository at this point in the history

  9. use click for now for some keyboard operations 

    focus management and certain elements arent working properly, see comments
    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c3be4bc View commit details
    Browse the repository at this point in the history

  10. fix keyboard interaction for sort column util

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a1e8183 View commit details
    Browse the repository at this point in the history

  11. figure out the proper timeout for realTimers

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    43e4f6d View commit details
    Browse the repository at this point in the history

  12. lint

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    18d6254 View commit details
    Browse the repository at this point in the history

  13. fix docs and build point

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    764d05f View commit details
    Browse the repository at this point in the history

  14. forgot comma in rebase

    @LFDanLu
    LFDanLu committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1eb5bcb View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Update packages/@react-spectrum/table/test/Table.test.js

    @LFDanLu
    LFDanLu committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d98153d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' into aria_pattern_utils

    @LFDanLu
    LFDanLu committed May 23, 2024
    Configuration menu
    Copy the full SHA
    241bd15 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch 'main' of github.com:adobe/react-spectrum into aria_patt… 

    …ern_utils
    @LFDanLu
    LFDanLu committed May 31, 2024
    Configuration menu
    Copy the full SHA
    6902d7f View commit details
    Browse the repository at this point in the history

  2. go with factory instead of having the testers created in constructor 

    this avoids possible issues with the same tester being used across multiple tests and getting in a weird state in parallel runs
    @LFDanLu
    LFDanLu committed May 31, 2024
    Configuration menu
    Copy the full SHA
    621abca View commit details
    Browse the repository at this point in the history