Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Aria pattern utils #6208

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

WIP Aria pattern utils #6208

wants to merge 15 commits into from

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Apr 16, 2024

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Apr 16, 2024

Build successful! 🎉

LFDanLu
LFDanLu commented Apr 16, 2024
View reviewed changes
packages/@react-spectrum/picker/test/TempUtilTest.test.js
@@ -0,0 +1,270 @@
/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder: remove this once the select utils v1 is finalized and everything runs clean

@rspbot
Copy link

rspbot commented Apr 16, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Apr 18, 2024

Build successful! 🎉

Base automatically changed from bring_back_utils to main April 22, 2024 19:52
@LFDanLu
rough progress in refactoring api and testing timers
ca702b9
@LFDanLu
update RAC select tests to use the select util
b0ea3a6
@LFDanLu
fix edge cases and add flows for different interaction patterns
a7c832d
@LFDanLu
adding sections and removing valueElement, wrapping up final conversi…
faae16e 
…ons for Picker tests

only modified some of the Picker tests to leverage the utils where I deemed appropriate. Mainly where selection/opening of the Picker wasnt the main focus of the test or if the test itself wasnt checking stuff about the item nodes themselves.
@LFDanLu
add initial table util scaffolding
65680b0 
mostly from old PR, adapted to fit the new api
@LFDanLu
testing against the RAC tests/React 16/17
fd842c6 
had to add an increased test timeout for React 16 tests
@LFDanLu
more testing of long press, add findCell/findRow
287ce79
@LFDanLu
test all the different interaction types
6cf55db 
the keyboard sort change util function isnt working properly, investigating. The focus isnt being restored to the right place
@LFDanLu
use click for now for some keyboard operations
c3be4bc 
focus management and certain elements arent working properly, see comments
@LFDanLu
fix keyboard interaction for sort column util
a1e8183
@LFDanLu
figure out the proper timeout for realTimers
43e4f6d
@LFDanLu
lint
18d6254
@LFDanLu
fix docs and build point
764d05f
@rspbot
Copy link

rspbot commented Apr 23, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Apr 23, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@react-aria/test-utils

installPointerEvent

-
+User {
+  constructor: (UserOpts) => void
+  select: SelectTester
+  table: TableTester
+}

@react-spectrum/test-utils

simulateMobile

-
+User {
+  constructor: (UserOpts) => void
+  select: SelectTester
+  table: TableTester
+}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LFDanLu @rspbot