-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus Management within Shadow DOM #6046
Open
MahmoudElsayad
wants to merge
58
commits into
adobe:main
Choose a base branch
from
ritz078:shadow-dom-enhancement-1-getRootNode
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
c026270
Add `getRootNode` utility.
MahmoudElsayad 9299cee
Update `getRootNode` util.
MahmoudElsayad 71836e3
Update `getOwnerWindow` util.
MahmoudElsayad 10893b9
Add tests for Shadow DOM handling using `getRootNode`.
MahmoudElsayad 5f81d34
Update comment.
MahmoudElsayad bfb9429
Fix FocusScope.tsx in Shadow DOM.
MahmoudElsayad 3448ed7
Add more test for FocusScope.test.js.
MahmoudElsayad 0c07404
Fix another `useRestoreFocus` issue with restoring focus in `Keyboard…
MahmoudElsayad 90906bf
Add tests for `getDeepActiveElement`
MahmoudElsayad 314fc44
Add `useFocus` shadow DOM tests.
MahmoudElsayad 9cb6c5a
Update `focusSafely`.
MahmoudElsayad 67399bb
Update `useInteractionOutside` for Shadow DOM support.
MahmoudElsayad 59c3705
Update `useFocusVisible` for Shadow DOM support.
MahmoudElsayad 3c85408
Add `useInteractOutside` tests.
MahmoudElsayad 61ba1b0
Add test for use case mentioned in issue #1472.
MahmoudElsayad 75d7fa5
Add tests for `usePress` hook.
MahmoudElsayad db45ef4
Update the fix for `useInteractOutside` to use simpler one.
MahmoudElsayad f9b94a3
Update `useOverlay` to use composedPath.
MahmoudElsayad 758575c
Tests refactor.
MahmoudElsayad 25ef5c5
Revert `useOverlay` changes as it works correctly without these changes.
MahmoudElsayad 0d4f70e
Fix types.
MahmoudElsayad 3cf2091
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad 1d8c439
Fix types.
MahmoudElsayad e5dbda1
lint.
MahmoudElsayad ae7b76e
lint.
MahmoudElsayad aea5d8d
Fix failing tests.
MahmoudElsayad f2ca9b7
Fix failing tests.
MahmoudElsayad 4d6ff95
Fix failing tests.
MahmoudElsayad 4c53797
Test CI
MahmoudElsayad 85b7146
Test CI
MahmoudElsayad a001f2a
Fix shadow DOM tests
MahmoudElsayad d00f0b2
Fix shadow DOM tests.
MahmoudElsayad e875828
Fix CI?
MahmoudElsayad b483e61
Fix CI?
MahmoudElsayad b8ef055
Fix CI?
MahmoudElsayad cc2a7c4
Re-add commented test.
MahmoudElsayad 7447a79
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
ritz078 492d83f
Update `getRootNode` to handle iframes as well, and everything that …
MahmoudElsayad 139a209
Merge remote-tracking branch 'upstream/main' into shadow-dom-enhancem…
MahmoudElsayad 805561b
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger a319991
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad dc2231d
Fix tests.
MahmoudElsayad bd536b6
Fix tests?
MahmoudElsayad f1aa64a
Fix tests?
MahmoudElsayad 6426c08
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad 7cafb6a
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad 1a3e068
Fix tests.
MahmoudElsayad f1fe364
Fix tests.?
MahmoudElsayad 24550d6
Fix tests.?
MahmoudElsayad b9a11ee
Fix tests.?
MahmoudElsayad 97d73f2
Fix tests.?
MahmoudElsayad 720ee18
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad 6f80dbc
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger 6ca6996
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger 1f6ecf3
Apply suggestions from code review
MahmoudElsayad 13278d9
Update packages/@react-aria/interactions/test/usePress.test.js
MahmoudElsayad 93a5071
- Update tests to use `createShadowRoot` util.
MahmoudElsayad 4ca6f75
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?