Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus Management within Shadow DOM #6046

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Focus Management within Shadow DOM #6046

wants to merge 58 commits into from

Commits on Mar 11, 2024

  1. Add getRootNode utility.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c026270 View commit details
    Browse the repository at this point in the history

  2. Update getRootNode util. 

    Update domHelpers.test.js.
    @MahmoudElsayad
    MahmoudElsayad committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9299cee View commit details
    Browse the repository at this point in the history

  3. Update getOwnerWindow util.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    71836e3 View commit details
    Browse the repository at this point in the history

  4. Add tests for Shadow DOM handling using getRootNode.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    10893b9 View commit details
    Browse the repository at this point in the history

  5. Update comment.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    5f81d34 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Fix FocusScope.tsx in Shadow DOM. 

    Add Tests for FocusScope.test.js.
New helper util `getRootBody`.
    @MahmoudElsayad
    MahmoudElsayad committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bfb9429 View commit details
    Browse the repository at this point in the history

  2. Add more test for FocusScope.test.js. 

    Fix `useRestoreFocus` issue.
Add new DOM util `getDeepActiveElement`.
    @MahmoudElsayad
    MahmoudElsayad committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    3448ed7 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Fix another useRestoreFocus issue with restoring focus in `Keyboard… 

    … navigation example`.
    @MahmoudElsayad
    MahmoudElsayad committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0c07404 View commit details
    Browse the repository at this point in the history

  2. Add tests for getDeepActiveElement

    @MahmoudElsayad
    MahmoudElsayad committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    90906bf View commit details
    Browse the repository at this point in the history

  3. Add useFocus shadow DOM tests. 

    update `useFocus` - `useFocusWithin` - `usePress`.
    @MahmoudElsayad
    MahmoudElsayad committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    314fc44 View commit details
    Browse the repository at this point in the history

  4. Update focusSafely. 

    Test for `focusSafely`.
    @MahmoudElsayad
    MahmoudElsayad committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9cb6c5a View commit details
    Browse the repository at this point in the history

  5. Update useInteractionOutside for Shadow DOM support.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    67399bb View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Update useFocusVisible for Shadow DOM support.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    59c3705 View commit details
    Browse the repository at this point in the history

  2. Add useInteractOutside tests.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3c85408 View commit details
    Browse the repository at this point in the history

  3. Add test for use case mentioned in issue adobe#1472.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    61ba1b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Add tests for usePress hook.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    75d7fa5 View commit details
    Browse the repository at this point in the history

  2. Update the fix for useInteractOutside to use simpler one.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    db45ef4 View commit details
    Browse the repository at this point in the history

  3. Update useOverlay to use composedPath.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f9b94a3 View commit details
    Browse the repository at this point in the history

  4. Tests refactor.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    758575c View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Revert useOverlay changes as it works correctly without these changes.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    25ef5c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Fix types.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0d4f70e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @MahmoudElsayad
    MahmoudElsayad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3cf2091 View commit details
    Browse the repository at this point in the history

  3. Fix types.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1d8c439 View commit details
    Browse the repository at this point in the history

  4. lint.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e5dbda1 View commit details
    Browse the repository at this point in the history

  5. lint.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ae7b76e View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Fix failing tests.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    aea5d8d View commit details
    Browse the repository at this point in the history

  2. Fix failing tests.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f2ca9b7 View commit details
    Browse the repository at this point in the history

  3. Fix failing tests.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4d6ff95 View commit details
    Browse the repository at this point in the history

  4. Test CI

    @MahmoudElsayad
    MahmoudElsayad committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4c53797 View commit details
    Browse the repository at this point in the history

  5. Test CI

    @MahmoudElsayad
    MahmoudElsayad committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    85b7146 View commit details
    Browse the repository at this point in the history

  6. Fix shadow DOM tests

    @MahmoudElsayad
    MahmoudElsayad committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a001f2a View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Fix shadow DOM tests.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d00f0b2 View commit details
    Browse the repository at this point in the history

  2. Fix CI?

    @MahmoudElsayad
    MahmoudElsayad committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e875828 View commit details
    Browse the repository at this point in the history

  3. Fix CI?

    @MahmoudElsayad
    MahmoudElsayad committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b483e61 View commit details
    Browse the repository at this point in the history

  4. Fix CI?

    @MahmoudElsayad
    MahmoudElsayad committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b8ef055 View commit details
    Browse the repository at this point in the history

  5. Re-add commented test.

    @MahmoudElsayad
    MahmoudElsayad committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    cc2a7c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @ritz078
    ritz078 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7447a79 View commit details
    Browse the repository at this point in the history

  2. Update getRootNode to handle iframes as well, and everything that `… 

    …getOwnerDocument` used to handle.
    @MahmoudElsayad
    MahmoudElsayad committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    492d83f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge remote-tracking branch 'upstream/main' into shadow-dom-enhancem… 

    …ent-1-getRootNode
    @MahmoudElsayad
    MahmoudElsayad committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    139a209 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @snowystinger
    snowystinger committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    805561b View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @MahmoudElsayad
    MahmoudElsayad committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a319991 View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @MahmoudElsayad
    MahmoudElsayad committed May 7, 2024
    Configuration menu
    Copy the full SHA
    dc2231d View commit details
    Browse the repository at this point in the history

  3. Fix tests?

    @MahmoudElsayad
    MahmoudElsayad committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bd536b6 View commit details
    Browse the repository at this point in the history

  4. Fix tests?

    @MahmoudElsayad
    MahmoudElsayad committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f1aa64a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @MahmoudElsayad
    MahmoudElsayad committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6426c08 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @MahmoudElsayad
    MahmoudElsayad committed May 20, 2024
    Configuration menu
    Copy the full SHA
    7cafb6a View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Fix tests.

    @MahmoudElsayad
    MahmoudElsayad committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1a3e068 View commit details
    Browse the repository at this point in the history

  2. Fix tests.?

    @MahmoudElsayad
    MahmoudElsayad committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f1fe364 View commit details
    Browse the repository at this point in the history

  3. Fix tests.?

    @MahmoudElsayad
    MahmoudElsayad committed May 21, 2024
    Configuration menu
    Copy the full SHA
    24550d6 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Fix tests.?

    @MahmoudElsayad
    MahmoudElsayad committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b9a11ee View commit details
    Browse the repository at this point in the history

  2. Fix tests.?

    @MahmoudElsayad
    MahmoudElsayad committed May 22, 2024
    Configuration menu
    Copy the full SHA
    97d73f2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @MahmoudElsayad
    MahmoudElsayad committed May 22, 2024
    Configuration menu
    Copy the full SHA
    720ee18 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @snowystinger
    snowystinger committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6f80dbc View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @snowystinger
    snowystinger committed May 28, 2024
    Configuration menu
    Copy the full SHA
    6ca6996 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Robert Snow <snowystinger@gmail.com>
    @MahmoudElsayad @snowystinger
    MahmoudElsayad and snowystinger committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1f6ecf3 View commit details
    Browse the repository at this point in the history

  3. Update packages/@react-aria/interactions/test/usePress.test.js 

    Co-authored-by: Robert Snow <snowystinger@gmail.com>
    @MahmoudElsayad @snowystinger
    MahmoudElsayad and snowystinger committed May 28, 2024
    Configuration menu
    Copy the full SHA
    13278d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. - Update tests to use createShadowRoot util. 

    - Update `getRootNode` to return null for disconnected nodes.
- Update `usePress.test.js` shadow DOM test.
- Test getting rid of reactDomRenderer.
    @MahmoudElsayad
    MahmoudElsayad committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    93a5071 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into shadow-dom-enhancement-1-getRootNode

    @MahmoudElsayad
    MahmoudElsayad committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4ca6f75 View commit details
    Browse the repository at this point in the history