Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ClientLibraries] Add option to inject the onload attribute into the stylesheet link tag #2692

Merged
merged 4 commits into from Apr 30, 2024

Conversation

vladbailescu
Copy link
Member

…stylesheet link tag (#2296)

* [ClientLibraries] Add option to inject the onload attribute into the stylesheet link tag
* [ClientLibraries] Inject existing onload attribute into the stylesheet link tag
Fixes #2295
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (0e127b2) to head (280fdb6).
Report is 395 commits behind head on main.

❗ Current head 280fdb6 differs from pull request most recent head 5078cfc. Consider uploading reports for the commit 5078cfc to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2692      +/-   ##
============================================
+ Coverage     86.60%   87.21%   +0.61%     
- Complexity     2313     2673     +360     
============================================
  Files           210      233      +23     
  Lines          6161     7128     +967     
  Branches        931     1090     +159     
============================================
+ Hits           5336     6217     +881     
- Misses          329      361      +32     
- Partials        496      550      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrei-Cornea
Copy link

Hi @vladbailescu is there any plan to add the attribute type for the js script tag as well ?

<script **type="module"** src="main.js"></script>

Best Andrei

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@LSantha LSantha added this to the 2.25.0 milestone Apr 29, 2024
@LSantha LSantha merged commit ec57de2 into main Apr 30, 2024
8 of 16 checks passed
@LSantha LSantha deleted the issues/2295 branch April 30, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ClientLibraries] Add option to inject the onload attribute into the stylesheet link tag
4 participants