Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2295: [ClientLibraries] Add option to inject the onload attribute int… #2296

Merged

Conversation

korben-ne-dallas
Copy link
Contributor

@korben-ne-dallas korben-ne-dallas commented Sep 2, 2022

…o the stylesheet link tag

Q                       A
Fixed Issues? Fixes #2295
Patch: Bug Fix?
Minor: New Feature? Yes
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Added option to inject the onload attribute into the stylesheet link tag

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (efb0bde) to head (a81bee3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2296   +/-   ##
=========================================
  Coverage     87.17%   87.17%           
  Complexity     2668     2668           
=========================================
  Files           233      233           
  Lines          7128     7129    +1     
  Branches       1090     1090           
=========================================
+ Hits           6214     6215    +1     
  Misses          363      363           
  Partials        551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladbailescu vladbailescu merged commit 55a9b8d into adobe:main Mar 2, 2024
10 checks passed
@vladbailescu
Copy link
Member

After merging this one of the HTTP ITs are failing:

java.lang.AssertionError: Incorrect link and/or link attributes
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at com.adobe.cq.testing.junit.assertion.GraniteAssert.assertRegExFind(GraniteAssert.java:88)
	at com.adobe.cq.testing.junit.assertion.GraniteAssert.assertRegExFind(GraniteAssert.java:77)
	at com.adobe.cq.wcm.core.components.it.http.ClientlibsIncludeIT.testAllInclude(ClientlibsIncludeIT.java:70)

vladbailescu added a commit that referenced this pull request Mar 4, 2024
…nto the stylesheet link tag (#2296)"

This reverts commit 55a9b8d.
vladbailescu pushed a commit that referenced this pull request Mar 4, 2024
…stylesheet link tag (#2296)

* [ClientLibraries] Add option to inject the onload attribute into the stylesheet link tag
* [ClientLibraries] Inject existing onload attribute into the stylesheet link tag
Fixes #2295
@vladbailescu
Copy link
Member

Reverted the merge and pushed the changes to a branch (#2692) to fix the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ClientLibraries] Add option to inject the onload attribute into the stylesheet link tag
3 participants