-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content Fragment List] Add "All Tag" match ability #2382
base: main
Are you sure you want to change the base?
Commits on Nov 23, 2022
-
Improve
ContentFragmentListImplTest
tag predicate testingUpdates the tag predicate testing to ensure that there are no additional predicates in the actual predicate group that were not present in the expected predicate group. ---- refs adobe#2381
Configuration menu - View commit details
-
Copy full SHA for 531ecc4 - Browse repository at this point
Copy the full SHA 531ecc4View commit details -
Update Content Fragment List model to allow "all tag" requirement
Updates the Content Fragment List component model so to add the ability to require all tags to match instead of any tag (i.e. us `AND` instead of the default `OR`). This is similar to the List component and makes use of the same property name (`./tagsMatch`). Additionally, injected properties are removed when they can easily be derived from other injected objects and aren't used outside of the initializer method - and so there is no reason to hold on to them for the entire lifespan of the object. Furthermore, resources resolved from the leaky query builder resource resolver are re-resolved with the non-leaky resource resolver before being used. This is done to ensure that no reference to the leaky resource resolver persists after it is closed. ---- refs adobe#2381
Configuration menu - View commit details
-
Copy full SHA for a047406 - Browse repository at this point
Copy the full SHA a047406View commit details -
Add tag match (any/all) dialog option to Content Fragment List
Adds an option in the Content Fragment List dialog to select if the tag matching should be `Any` or `All`. The model will use an `or` or an `and` condition in the tag predicate based on this choice. This dialog option is copied directly from the List component dialog. ---- refs adobe#2381
Configuration menu - View commit details
-
Copy full SHA for f2fc29f - Browse repository at this point
Copy the full SHA f2fc29fView commit details -
Add mention of "all tags" match ability to CF List example content
Adds text to the Content Fragment List component example content that indicates that "all tags" matching is possible. This text is copied from the List component example content. ---- refs adobe#2381
Configuration menu - View commit details
-
Copy full SHA for 1220eb5 - Browse repository at this point
Copy the full SHA 1220eb5View commit details
Commits on Nov 24, 2022
-
Improve fail messages in Content Fragment List predicate tests
Improves the failure message to communicate exactly why the predicate did not match.
Configuration menu - View commit details
-
Copy full SHA for 09b6cd0 - Browse repository at this point
Copy the full SHA 09b6cd0View commit details
Commits on Jan 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9372db7 - Browse repository at this point
Copy the full SHA 9372db7View commit details