Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content Fragment List] Add "All Tag" match ability #2382

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Nov 23, 2022

  1. Improve ContentFragmentListImplTest tag predicate testing

    Updates the tag predicate testing to ensure that there are no
    additional predicates in the actual predicate group that were
    not present in the expected predicate group.
    
    ----
    refs adobe#2381
    ky940819 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    531ecc4 View commit details
    Browse the repository at this point in the history
  2. Update Content Fragment List model to allow "all tag" requirement

    Updates the Content Fragment List component model so to add the
    ability to require all tags to match instead of any tag (i.e. us
    `AND` instead of the default `OR`).
    
    This is similar to the List component and makes use of the same
    property name (`./tagsMatch`).
    
    Additionally, injected properties are removed when they can easily
    be derived from other injected objects and aren't used outside of
    the initializer method - and so there is no reason to hold on to them
    for the entire lifespan of the object.
    
    Furthermore, resources resolved from the leaky query builder resource
    resolver are re-resolved with the non-leaky resource resolver before
    being used. This is done to ensure that no reference to the leaky
    resource resolver persists after it is closed.
    
    ----
    refs adobe#2381
    ky940819 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    a047406 View commit details
    Browse the repository at this point in the history
  3. Add tag match (any/all) dialog option to Content Fragment List

    Adds an option in the Content Fragment List dialog to select if the
    tag matching should be `Any` or `All`. The model will use an `or` or
    an `and` condition in the tag predicate based on this choice.
    
    This dialog option is copied directly from the List component dialog.
    
    ----
    refs adobe#2381
    ky940819 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    f2fc29f View commit details
    Browse the repository at this point in the history
  4. Add mention of "all tags" match ability to CF List example content

    Adds text to the Content Fragment List component example content that
    indicates that "all tags" matching is possible. This text is copied
    from the List component example content.
    
    ----
    refs adobe#2381
    ky940819 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    1220eb5 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Improve fail messages in Content Fragment List predicate tests

    Improves the failure message to communicate exactly why the
    predicate did not match.
    ky940819 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    09b6cd0 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Configuration menu
    Copy the full SHA
    9372db7 View commit details
    Browse the repository at this point in the history