[Content Fragment List] Add "All Tag" match ability #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the tag predicate testing to ensure that there are no additional predicates in the actual predicate group that were not present in the expected predicate group. ---- refs adobe#2381
Updates the Content Fragment List component model so to add the ability to require all tags to match instead of any tag (i.e. us `AND` instead of the default `OR`). This is similar to the List component and makes use of the same property name (`./tagsMatch`). Additionally, injected properties are removed when they can easily be derived from other injected objects and aren't used outside of the initializer method - and so there is no reason to hold on to them for the entire lifespan of the object. Furthermore, resources resolved from the leaky query builder resource resolver are re-resolved with the non-leaky resource resolver before being used. This is done to ensure that no reference to the leaky resource resolver persists after it is closed. ---- refs adobe#2381
Adds an option in the Content Fragment List dialog to select if the tag matching should be `Any` or `All`. The model will use an `or` or an `and` condition in the tag predicate based on this choice. This dialog option is copied directly from the List component dialog. ---- refs adobe#2381
Adds text to the Content Fragment List component example content that indicates that "all tags" matching is possible. This text is copied from the List component example content. ---- refs adobe#2381
Codecov Report
@@ Coverage Diff @@
## main #2382 +/- ##
============================================
+ Coverage 87.25% 87.28% +0.03%
Complexity 2518 2518
============================================
Files 220 220
Lines 6724 6734 +10
Branches 1019 1018 -1
============================================
+ Hits 5867 5878 +11
Misses 340 340
+ Partials 517 516 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Improves the failure message to communicate exactly why the predicate did not match.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Content Fragment List component to allow matching either "Any Tags" or "All Tags".
This is accomplished by:
andororcondition is used for tag matching.In addition to these changes, the following was also changed:
README.MDto add the new./tagsMatchproperty to theEdit Dialog Propertiessection.