Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form Action Dialog] fix required validation for property on Form Action dialog and also fix the issue of saving the property as multiarray when the same name exists in diff form action dialog #2110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Form Action Dialog] fix required validation for property on Form Action dialog and also fix the issue of saving the property as multiarray when the same name exists in diff form action dialog #2110

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf18127
fixed #2052 and #2056
punithshetty90 Mar 24, 2022
35e645a
Merge branch 'main' into issue-2052-and-2056
punithshetty90 Jun 21, 2022
533633d
Merge branch 'main' into issue-2052-and-2056
punithshetty90 Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
51 changes: 39 additions & 12 deletions ...ot/apps/core/wcm/components/form/container/v2/container/clientlibs/editor/js/container.js
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
******************************************************************************/
(function(document, $, Coral) {
(function(document, $, Coral) {
"use strict";

var ACTION_TYPE_SETTINGS_SELECTOR = "#cmp-action-type-settings";
Expand Down Expand Up @@ -112,31 +112,58 @@
function setVisibilityAndHandleFieldValidation($element, show) {
if (show) {
$element.removeClass("hide");
$element.find("input[aria-required=false], coral-multifield[aria-required=false]").
filter(":not(.hide>input)").filter(":not(input.hide)").
filter(":not(.hide>coral-multifield)").filter(":not(input.coral-multifield)").each(function(index, field) {
toggleValidation($(field));
});
// for preventing storing as string[], if same name is present in other form dialog
$element.find("input").filter(":not(.hide>input)").filter(":not(input.hide)").each(function (index, field) {
toggleDisable($(field), false);
});
// for handling textbox, textarea, select, checkbox, pathfield etc
$element.find("[aria-required=false]").filter(":not(.hide>*)").each(function (index, field) {
toggleValidation($(field), true);
});
} else {
$element.addClass("hide");
$element.find("input[aria-required=true], coral-multifield[aria-required=true]").each(function(index, field) {
toggleValidation($(field));
// for preventing storing as string[], if same name is present in other form dialog
$element.find("input").each(function (index, field) {
toggleDisable($(field), true);
});
// for handling textbox, textarea, select, checkbox, pathfield etc
$element.find("[aria-required=true],[required]").each(function (index, field) {
toggleValidation($(field), false);
});
}
}

/**
* If the form actions have same name for 2 different form action, we need to disable the form dialog properties from actions which are not selected in the dropdown
*
* @param {jQuery} $field To disable
*/
function toggleDisable($field, disable) {
if (disable) {
$field.prop("disabled", true);
} else {
$field.prop("disabled", false);
}
}

/**
* If the form element is not shown we have to disable the required validation for that field.
*
* @param {jQuery} $field To disable / enable required validation.
*/
function toggleValidation($field) {
function toggleValidation($field, show) {
var notRequired = false;
if ($field.attr("aria-required") === "true") {
if (!show) {
notRequired = true;
$field.attr("aria-required", "false");
} else if ($field.attr("aria-required") === "false") {
$field.attr("aria-required", "true");
/** Custom AMD Code Starts */
$field.removeAttr("required");
/** Custom AMD Code ends */
} else {
$field.attr("aria-required", "true");
/** Custom AMD Code Starts */
$field.attr("required", "required");
/** Custom AMD Code ends */
}
var api = $field.adaptTo("foundation-validation");
if (api) {
Expand Down