[Form Action Dialog] fix required validation for property on Form Action dialog and also fix the issue of saving the property as multiarray when the same name exists in diff form action dialog #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue adobe#2052 : Fix required validation for property on Form Action dialog Issue adobe#2056 : Fix the issue of saving the property as multiarray when the same name exists in diff form action dialog
|
Kudos, SonarCloud Quality Gate passed!
|
punithshetty90
changed the title
|
SonarCloud Quality Gate failed.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue#2052: Instead of targeting just the input[aria-required=true], coral-multifield[aria-required=true] selectors, we need to genralize and target all [aria-required=true],[required] so that other sling:resourceTypes are also covered
issue#2056: Enable only the input forms which is selected in the dropdown, Make the rest of them disabled so that it doesn't save as string[] if the same name exists in another form action