Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FORMS-13935 update examples for aemcomponents.dev #1204

Merged
merged 1 commit into from
Apr 29, 2024
Merged

FORMS-13935 update examples for aemcomponents.dev #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ts-examples/clientlibs/forms-clientlib-site/styles/components/adaptive-form/fragment.less
View file
Open in desktop
@@ -0,0 +1,4 @@
.cmp-adaptiveform-fragment {
.descriptionMixin();

}
3 changes: 2 additions & 1 deletion ...ps/forms-components-examples/clientlibs/forms-clientlib-site/styles/components/index.less
View file
Open in desktop
Expand Up @@ -39,4 +39,5 @@
@import 'adaptive-form/verticaltabs.less';
@import 'adaptive-form/checkbox.less';
@import 'adaptive-form/termsandconditions.less';
@import 'adaptive-form/switch.less';
@import 'adaptive-form/switch.less';
@import "adaptive-form/fragment.less";
4 changes: 4 additions & 0 deletions examples/ui.content/src/main/content/META-INF/vault/filter.xml
View file
Open in desktop
Expand Up @@ -26,4 +26,8 @@
<filter root="/conf/core-components-examples/settings/wcm/policies/wcm/foundation/components/responsivegrid/page-header/jcr:content" mode="update"/>
<filter root="/conf/core-components-examples/settings/wcm/policies/wcm/foundation/components/responsivegrid/page-footer" mode="update"/>
<filter root="/conf/core-components-examples/settings/wcm/policies/wcm/foundation/components/responsivegrid/page-footer/jcr:content" mode="update"/>
<filter root="/content/forms/af/core-forms-components-examples/sample" mode="merge"/>
<filter root="/content/dam/formsanddocuments/core-forms-components-examples/sample" mode="merge"/>
<filter root="/content/forms/af/core-forms-components-examples/test-fragment" mode="merge"/>
<filter root="/content/dam/formsanddocuments/core-forms-components-examples/test-fragment" mode="merge"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incorrect to me. The whole point of aemcomponents.dev is to describe components. The page used in the examples is always a SITE page.

While I agree that fragment have a requiremenet to be under /content/forms/af, the sample page used is incorrect. Please refer on how text input is demonstrated and try using a fragment inside an existing SITES page, let's not create a PAGE inside /content/forms/af

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page use for fragment and embed both are SITE pages . e.g. examples/ui.content/src/main/content/jcr_root/content/core-components-examples/library/adaptive-form/fragment/.content.xml
But since we need to embed an adaptive form & an adaptive form fragment in these SITE pages, so the adaptive form and fragment are placed under /content/forms/af

The text input use case is not relevant here because text input is just a component under a form container in a SITE page. Here these are embed components which need a reference to an adaptive form.

</workspaceFilter>
190 changes: 107 additions & 83 deletions ...oot/content/core-components-examples/library/adaptive-form/aemembedcontainer/.content.xml
View file
Open in desktop
@@ -1,96 +1,120 @@
<?xml version="1.0" encoding="UTF-8"?>
<jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0"
jcr:primaryType="cq:Page">
jcr:primaryType="cq:Page">
<jcr:content
cq:lastModified="{Date}2023-04-18T12:30:56.377+05:30"
cq:lastModifiedBy="admin"
cq:tags="[]"
cq:template="/conf/core-components-examples/settings/wcm/templates/content-page"
jcr:description="Aem Embed Container"
jcr:primaryType="cq:PageContent"
jcr:title="Aem Embed Container"
sling:resourceType="forms-components-examples/components/page">
cq:lastModified="{Date}2024-04-22T18:04:19.339+05:30"
cq:lastModifiedBy="admin"
cq:tags="[]"
cq:template="/conf/core-components-examples/settings/wcm/templates/content-page"
jcr:description="Aem Embed Container"
jcr:primaryType="cq:PageContent"
jcr:title="Aem Embed Container"
sling:resourceType="forms-components-examples/components/page">
<root
jcr:primaryType="nt:unstructured"
sling:resourceType="wcm/foundation/components/responsivegrid">
jcr:primaryType="nt:unstructured"
sling:resourceType="wcm/foundation/components/responsivegrid">
<responsivegrid
jcr:primaryType="nt:unstructured"
sling:resourceType="wcm/foundation/components/responsivegrid">
jcr:primaryType="nt:unstructured"
sling:resourceType="wcm/foundation/components/responsivegrid">
<text_1158214514
jcr:created="{Date}2024-04-22T14:37:03.035+05:30"
jcr:createdBy="admin"
jcr:lastModified="{Date}2024-04-22T14:39:25.732+05:30"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="core-components-examples/components/text"
text="&lt;p>&lt;b>Aem Embed Container in Non-iframe mode&lt;/b>&lt;/p>&#xd;&#xa;"
textIsRich="true"/>
<text_1740702241
cq:styleIds="[1644862132301]"
jcr:lastModified="{Date}2019-02-15T19:09:39.787+01:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="core/wcm/components/text/v2/text"
text="&lt;h1>Aem Embed Container &lt;sub>v1&lt;/sub>&lt;/h1>"
textIsRich="true"/>
cq:styleIds="[1644862132301]"
jcr:lastModified="{Date}2019-02-15T19:09:39.787+01:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="core/wcm/components/text/v2/text"
text="&lt;h1>Aem Embed Container &lt;sub>v1&lt;/sub>&lt;/h1>"
textIsRich="true"/>
<text
cq:styleIds="[1544762734201]"
jcr:lastModified="{Date}2020-07-15T13:25:39.729+02:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="core/wcm/components/text/v2/text"
text="&lt;p>Aem Embed Container Core Component allows users to embed Adaptive form in sites in iframe and non iframe mode .&lt;/p>"
textIsRich="true"/>
cq:styleIds="[1544762734201]"
jcr:lastModified="{Date}2020-07-15T13:25:39.729+02:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="core/wcm/components/text/v2/text"
text="&lt;p>Aem Embed Container Core Component allows users to embed Adaptive form in sites in iframe and non iframe mode .&lt;/p>"
textIsRich="true"/>
<teaser
cq:styleIds="[1550165685463]"
jcr:description="&lt;p>GitHub&lt;/p>&#xd;&#xa;"
jcr:lastModified="{Date}2019-02-14T16:49:57.290+01:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
jcr:title="Technical Documentation"
sling:resourceType="core-components-examples/components/teaser"
actionsEnabled="false"
descriptionFromPage="false"
fileReference="/content/dam/core-components-examples/library/github-logo.svg"
linkURL="https://github.com/adobe/aem-core-forms-components/tree/master/ui.apps/src/main/content/jcr_root/apps/core/fd/components/aemform/v2/aemform"
textIsRich="true"
titleFromPage="false"/>
cq:styleIds="[1550165685463]"
jcr:description="&lt;p>GitHub&lt;/p>&#xd;&#xa;"
jcr:lastModified="{Date}2019-02-14T16:49:57.290+01:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
jcr:title="Technical Documentation"
sling:resourceType="core-components-examples/components/teaser"
actionsEnabled="false"
descriptionFromPage="false"
fileReference="/content/dam/core-components-examples/library/github-logo.svg"
linkURL="https://github.com/adobe/aem-core-forms-components/tree/master/ui.apps/src/main/content/jcr_root/apps/core/fd/components/aemform/v2/aemform"
textIsRich="true"
titleFromPage="false"/>
<title_865328580
cq:styleIds="[1544759664489]"
jcr:lastModified="{Date}2018-12-06T19:23:25.116+01:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
jcr:title="Examples"
sling:resourceType="core/wcm/components/title/v2/title"
type="h2"/>
cq:styleIds="[1544759664489]"
jcr:lastModified="{Date}2018-12-06T19:23:25.116+01:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
jcr:title="Examples"
sling:resourceType="core/wcm/components/title/v2/title"
type="h2"/>
<title_290384408
cq:styleIds="[1544759676459]"
jcr:lastModified="{Date}2019-05-22T11:01:40.926+03:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
jcr:title="Standard"
sling:resourceType="core/wcm/components/title/v2/title"
type="h3"/>
<text_1337506761
jcr:lastModified="{Date}2019-05-22T11:26:32.604+03:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="core/wcm/components/text/v2/text"
text="&lt;p>Aem Embed Container in iframe mode &lt;/p>"
textIsRich="true"/>
<aemform
jcr:lastModified="{Date}2023-04-18T12:00:39.643+05:30"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="forms-components-examples/components/aemform"
enableFocusOnFirstField="{Boolean}true"
formRef="/content/dam/formsanddocuments/core-components-it/samples/numberinput/basic"
submitType="inline"
textIsRich="true"
useiframe="true"
usePageLocale="true"/>
<aemform_1104115969
jcr:lastModified="{Date}2023-04-18T12:30:56.364+05:30"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="forms-components-examples/components/aemform"
enableFocusOnFirstField="{Boolean}true"
formRef="/content/dam/formsanddocuments/core-components-it/samples/textinput/basic"
submitType="inline"
textIsRich="true"
useiframe="false"
usePageLocale="true"/>
cq:styleIds="[1544759676459]"
jcr:lastModified="{Date}2019-05-22T11:01:40.926+03:00"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
jcr:title="Standard"
sling:resourceType="core/wcm/components/title/v2/title"
type="h3"/>
<demo
jcr:created="{Date}2024-04-22T18:01:04.628+05:30"
jcr:createdBy="admin"
jcr:lastModified="{Date}2024-04-22T18:01:04.628+05:30"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="core-components-examples/components/demo">
<component
jcr:primaryType="nt:unstructured"
sling:resourceType="core-components-examples/components/demo/component">
<aemform
jcr:created="{Date}2024-04-22T18:01:09.788+05:30"
jcr:createdBy="admin"
jcr:lastModified="{Date}2024-04-22T18:01:22.646+05:30"
jcr:lastModifiedBy="admin"
jcr:primaryType="nt:unstructured"
sling:resourceType="forms-components-examples/components/aemform"
enableFocusOnFirstField="{Boolean}true"
formRef="/content/dam/formsanddocuments/core-forms-components-examples/sample"
submitType="inline"
textIsRich="true"
useiframe="false"
usePageLocale="true"/>
</component>
<info
jcr:primaryType="nt:unstructured"
sling:resourceType="core-components-examples/components/tabs">
<properties
cq:panelTitle="Properties"
jcr:primaryType="nt:unstructured"
sling:resourceType="core-components-examples/components/demo/properties"
reference="../../component"/>
<markup
cq:panelTitle="Markup"
jcr:primaryType="nt:unstructured"
sling:resourceType="core-components-examples/components/demo/markup"
reference="../../component"/>
<json
cq:panelTitle="JSON"
jcr:primaryType="nt:unstructured"
sling:resourceType="core-components-examples/components/demo/json"
reference="../../component"/>
</info>
</demo>
</responsivegrid>
</root>
</jcr:content>
Expand Down