FORMS-13935 update examples for aemcomponents.dev #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
barshat7
force-pushed
the
FORMS-13935-aemcomponents_dev
branch
from
17ed8d5
to
e2c0985
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev
barshat7
force-pushed
the
FORMS-13935-aemcomponents_dev
branch
from
e2c0985
to
482d2e1
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1204 +/- ##
=========================================
Coverage 80.81% 80.81%
Complexity 782 782
=========================================
Files 91 91
Lines 2116 2116
Branches 286 286
=========================================
Hits 1710 1710
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Apr 25, 2024
| <filter root="/content/forms/af/core-forms-components-examples/sample" mode="merge"/> | ||
| <filter root="/content/dam/formsanddocuments/core-forms-components-examples/sample" mode="merge"/> | ||
| <filter root="/content/forms/af/core-forms-components-examples/test-fragment" mode="merge"/> | ||
| <filter root="/content/dam/formsanddocuments/core-forms-components-examples/test-fragment" mode="merge"/> |
There was a problem hiding this comment.
This looks incorrect to me. The whole point of aemcomponents.dev is to describe components. The page used in the examples is always a SITE page.
While I agree that fragment have a requiremenet to be under /content/forms/af, the sample page used is incorrect. Please refer on how text input is demonstrated and try using a fragment inside an existing SITES page, let's not create a PAGE inside /content/forms/af
There was a problem hiding this comment.
The page use for fragment and embed both are SITE pages . e.g. examples/ui.content/src/main/content/jcr_root/content/core-components-examples/library/adaptive-form/fragment/.content.xml
But since we need to embed an adaptive form & an adaptive form fragment in these SITE pages, so the adaptive form and fragment are placed under /content/forms/af
The text input use case is not relevant here because text input is just a component under a form container in a SITE page. Here these are embed components which need a reference to an adaptive form.
rismehta
approved these changes
Apr 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2024
FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: