FORMS-14013 - Testcase added - Fixing Dropdown that had a selected value without default/placeholder set #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
dropd_fix
branch
from
26b89dd
to
bcdf85e
Compare
Merged
10 tasks
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1203 +/- ##
=========================================
Coverage 80.81% 80.81%
Complexity 782 782
=========================================
Files 91 91
Lines 2116 2116
Branches 286 286
=========================================
Hits 1710 1710
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Apr 23, 2024
| @@ -223,4 +223,13 @@ describe("Form with Dropdown", () => { | |||
| cy.get(`#${id}`).should('have.class', 'cmp-adaptiveform-dropdown--filled'); | |||
| }); | |||
| }); | |||
|
|
|||
| it("should have empty value checked when default option is not configured", () => { | |||
There was a problem hiding this comment.
The changes in this PR pertains to the view layer, while the test case is checking model. Please add test case for the changes done.
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
Apr 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2024
…lue without default/placeholder set (#1203) * Added test case * Adding actual fix * Improved test case * Small fix
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
…lue without default/placeholder set (#1203) * Added test case * Adding actual fix * Improved test case * Small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: